You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by drigodwin <gi...@git.apache.org> on 2017/04/13 17:17:44 UTC
[GitHub] brooklyn-library pull request #99: Update random passwords
GitHub user drigodwin opened a pull request:
https://github.com/apache/brooklyn-library/pull/99
Update random passwords
`Strings.makeRandomId` uses a insecure random so we shouldn't be using it for passwords, I've swapped it to `Identifiers.makeRandomPassword` which does use secure random.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/drigodwin/brooklyn-library fix-random-password
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit cb237cde3ca881b75af02af2e3cf4578af691ff1
Author: Duncan Godwin <du...@cloudsoftcorp.com>
Date: 2017-04-13T17:12:40Z
Fix random password
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #99: Update random passwords
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the issue:
https://github.com/apache/brooklyn-library/pull/99
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #99: Update random passwords
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---