Re: [PR] feat: Implement IPC RecordBatch body buffer compression [arrow-js]

["trxcllnt (via GitHub)" <gi...@apache.org>]

trxcllnt commented on PR #14:
URL: https://github.com/apache/arrow-js/pull/14#issuecomment-2931623322

   @Djjanks Since compression mode is an option on the reader and writer, the easiest way to integrate is probably to add/update the tests in [`stream-writer-tests.ts`](https://github.com/apache/arrow-js/blob/685399da37151f640201442ee387b1ddf425173b/test/unit/ipc/writer/stream-writer-tests.ts#L47) and [`file-writer-tests.ts`](https://github.com/apache/arrow-js/blob/685399da37151f640201442ee387b1ddf425173b/test/unit/ipc/writer/file-writer-tests.ts#L38). The `testStreamWriter` and `testFileWriter` helper functions can accept the writer options and verify the input table round-trips through the writer -> reader successfully. It looks like the RecordBatchFileWriter tests need to be updated to accept writer options, and both will need to also pass the compression option to the reader, but that should be straightforward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org