You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "adriencaccia (via GitHub)" <gi...@apache.org> on 2024/07/29 09:53:05 UTC
[PR] feat: add CodSpeed to the project [arrow-rs]
adriencaccia opened a new pull request, #6150:
URL: https://github.com/apache/arrow-rs/pull/6150
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #6149
@samuelcolvin, I let you take it from here if you want :)
In order for it to work, https://codspeed.io/ needs to be installed on the organization and the repo.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
A new workflow `benchmark.yml` that runs on every PR and the default `master` branch.
The `criterion` dependency is changed to `codspeed-criterion-compat`.
The `eq scalar StringViewArray` bench is commented out, because it fails on the runner.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No.
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6150: feat: add CodSpeed to the project
URL: https://github.com/apache/arrow-rs/pull/6150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2255573951
> I'm 👍 👍 👍 for this, but I don't have permissions on the repo. I think installing this will require @alamb.
I double checked the permission that needed by CodSpeed. It only needs read permission which should be ok for the ASF INFRA team.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2255572686
I triggered the workflow on this PR but I think codspeed won't run until we merge it
One way to test is to make some PRs against your own fork of `arrow-rs` and run the actions there to test -- that is how we have tested github actions in the past
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "adriencaccia (via GitHub)" <gi...@apache.org>.
adriencaccia commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2401810019
Hey @Xuanwo, is there anything I can do to help merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-4814749899
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2260517149
> If I understand correctly, the way to allow those actions is to first merge this PR?
I think this may be due to ASF security policy: https://infra.apache.org/github-actions-policy.html
Looks like maybe we have to pin the action to a specific SHA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2401841339
> Hey @Xuanwo, is there anything I can do to help merge this?
Hi, we are waiting for the ASF INFRA team to review this request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "adriencaccia (via GitHub)" <gi...@apache.org>.
adriencaccia commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2260852304
> Looks like maybe we have to pin the action to a specific SHA?
I pinned the two actions to specific SHAs, the workflow [still fails](https://github.com/apache/arrow-rs/actions/runs/10183529904).
It seems they will still need to be manually approved somehow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2290554063
Hi, @adriencaccia the ASF INFRA team has question about the github app's permission request:
> Please explain why it needs access to email addresses. This is likely not allowed under the European GDPR.
Do you have any response to this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "adriencaccia (via GitHub)" <gi...@apache.org>.
adriencaccia commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2317740163
> Hi, @adriencaccia the ASF INFRA team has question about the github app's permission request:
>
> > Please explain why it needs access to email addresses. This is likely not allowed under the European GDPR.
>
> Do you have any response to this?
Hey @Xuanwo, we only access the email addresses of the members of a GitHub organization simply to ensure that a logged user on CodSpeed is indeed a member of this organization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "samuelcolvin (via GitHub)" <gi...@apache.org>.
samuelcolvin commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2255567381
I'm 👍 👍 👍 for this, but I don't have permissions on the repo. I think installing this will require @alamb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "adriencaccia (via GitHub)" <gi...@apache.org>.
adriencaccia commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2255902944
The `codspeed-benchmarks` fails with the following message: `moonrepo/setup-rust@v1 and codspeedhq/action@v3 are not allowed to be used in apache/arrow-rs`
> I triggered the workflow on this PR but I think codspeed won't run until we merge it
If I understand correctly, the way to allow those actions is to first merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2260860760
> Looks like maybe we have to pin the action to a specific SHA?
Hi, it doesn't work in this way. We need the INFRA team to approve those actions via jira tickets. Here is an example: https://issues.apache.org/jira/projects/INFRA/issues/INFRA-25997
I'm willing to help do this if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add CodSpeed to the project [arrow-rs]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #6150:
URL: https://github.com/apache/arrow-rs/pull/6150#issuecomment-2282812115
Hi, we have submit a ticket to enable codspeed: https://issues.apache.org/jira/browse/INFRA-26030. Maybe @alamb want to comment your same request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org