You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "guixiaowen (via GitHub)" <gi...@apache.org> on 2025/10/05 03:09:07 UTC
[PR] [AURON #1401]rename spark.auron.enable.scan to spark.auron.enable.filescan [auron]
guixiaowen opened a new pull request, #1402:
URL: https://github.com/apache/auron/pull/1402
…escan #1401
<!--
Thanks for sending a pull request! Please keep the following tips in mind:
- Start the PR title with the related issue ID, e.g. '[AURON #XXXX] Short summary...'.
- Make your PR title clear and descriptive, summarizing what this PR changes.
- Provide a concise example to reproduce the issue, if possible.
- Keep the PR description up to date with all changes.
-->
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1401
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
rename spark.auron.enable.scan to spark.auron.enable.filescan
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
Change the variable name.
# How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1401]rename spark.auron.enable.scan to spark.auron.enable.fileScan [auron]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on code in PR #1402:
URL: https://github.com/apache/auron/pull/1402#discussion_r2416315650
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
Review Comment:
> also change these configurations?
@richox r Thank you very much for reviewing the code. The changes have been completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1401]rename spark.auron.enable.scan to spark.auron.enable.fileScan [auron]
Posted by "richox (via GitHub)" <gi...@apache.org>.
richox commented on code in PR #1402:
URL: https://github.com/apache/auron/pull/1402#discussion_r2415462328
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
Review Comment:
also change these configurations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1401]rename spark.auron.enable.scan to spark.auron.enable.fileScan [auron]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #1402:
URL: https://github.com/apache/auron/pull/1402#issuecomment-3385220161
> LGTM
@ShreyeshArangath Thank you very much for reviewing the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1401]rename spark.auron.enable.scan to spark.auron.enable.filescan [auron]
Posted by "ShreyeshArangath (via GitHub)" <gi...@apache.org>.
ShreyeshArangath commented on code in PR #1402:
URL: https://github.com/apache/auron/pull/1402#discussion_r2404265099
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -97,7 +97,7 @@ import org.apache.auron.sparkver
object AuronConverters extends Logging {
def enableScan: Boolean =
Review Comment:
Rename this too?
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -97,7 +97,7 @@ import org.apache.auron.sparkver
object AuronConverters extends Logging {
def enableScan: Boolean =
- getBooleanConf("spark.auron.enable.scan", defaultValue = true)
+ getBooleanConf("spark.auron.enable.filescan", defaultValue = true)
Review Comment:
```suggestion
getBooleanConf("spark.auron.enable.fileScan", defaultValue = true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1401]rename spark.auron.enable.scan to spark.auron.enable.fileScan [auron]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on code in PR #1402:
URL: https://github.com/apache/auron/pull/1402#discussion_r2404291342
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -97,7 +97,7 @@ import org.apache.auron.sparkver
object AuronConverters extends Logging {
def enableScan: Boolean =
Review Comment:
> Rename this too?
@ShreyeshArangath done
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -97,7 +97,7 @@ import org.apache.auron.sparkver
object AuronConverters extends Logging {
def enableScan: Boolean =
- getBooleanConf("spark.auron.enable.scan", defaultValue = true)
+ getBooleanConf("spark.auron.enable.filescan", defaultValue = true)
Review Comment:
>
@ShreyeshArangath done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #1401]rename spark.auron.enable.scan to spark.auron.enable.fileScan [auron]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen closed pull request #1402: [AURON #1401]rename spark.auron.enable.scan to spark.auron.enable.fileScan
URL: https://github.com/apache/auron/pull/1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org