[tomcat] branch 9.0.x updated: Cleanup

[re...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new ea9b8c44af Cleanup
ea9b8c44af is described below

commit ea9b8c44af0fc155d202d4dc79eee1822158b7cb
Author: remm <re...@apache.org>
AuthorDate: Mon Sep 11 15:49:23 2023 +0200

    Cleanup
    
    Argument cannot be null, so remove check that triggered coverity.
---
 java/org/apache/catalina/servlets/CGIServlet.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/java/org/apache/catalina/servlets/CGIServlet.java b/java/org/apache/catalina/servlets/CGIServlet.java
index 2c03cf7601..a527f23758 100644
--- a/java/org/apache/catalina/servlets/CGIServlet.java
+++ b/java/org/apache/catalina/servlets/CGIServlet.java
@@ -909,8 +909,7 @@ public final class CGIServlet extends HttpServlet {
             String name = null;
             String scriptname = null;
 
-            if (webAppRootDir != null &&
-                    webAppRootDir.lastIndexOf(File.separator) == (webAppRootDir.length() - 1)) {
+            if (webAppRootDir.lastIndexOf(File.separator) == (webAppRootDir.length() - 1)) {
                 //strip the trailing "/" from the webAppRootDir
                 webAppRootDir = webAppRootDir.substring(0, (webAppRootDir.length() - 1));
             }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org