You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2010/12/28 07:10:46 UTC

[jira] Commented: (HBASE-3395) StoreScanner not being closed?

    [ https://issues.apache.org/jira/browse/HBASE-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975426#action_12975426 ] 

ryan rawson commented on HBASE-3395:
------------------------------------

ah good point, no it doesnt, and no it isnt a problem right now.  HFile.Reader.Scanner.close() doesnt exist and would be a noop.

In the future this might not be, so should probably be fixed.

> StoreScanner not being closed?
> ------------------------------
>
>                 Key: HBASE-3395
>                 URL: https://issues.apache.org/jira/browse/HBASE-3395
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.0
>            Reporter: Prakash Khemani
>            Assignee: Jonathan Gray
>
> In StoreScanner::next(List<KeyValue> outResult, int limit)
>         case SEEK_NEXT_ROW:
>           // This is just a relatively simple end of scan fix, to short-cut end us if there is a
>           // endKey in the scan.
>           if (!matcher.moreRowsMayExistAfter(kv)) {
>             outResult.addAll(results);
>             return false;
>           }
> close() is not being called before returning false. In all other cases close is called before returning false. May be this is a problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.