You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2014/12/03 09:02:16 UTC
[GitHub] spark pull request: Make sure tryToAcquire won't return a negative...
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/3575
Make sure tryToAcquire won't return a negative value
ShuffleMemoryManager.tryToAcquire may return a negative value. The unit test demonstrates this bug. It will output `0 did not equal -200 granted is negative`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-4715
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3575.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3575
----
commit 2a97eb6a9ecac6051dfc5f7fdd616a82244dce21
Author: zsxwing <zs...@gmail.com>
Date: 2014-12-03T07:56:31Z
Make sure tryToAcquire won't return a negative value
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4715][Core] Make sure tryToAcquire won'...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3575#issuecomment-65368722
[Test build #24080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24080/consoleFull) for PR 3575 at commit [`a193ae6`](https://github.com/apache/spark/commit/a193ae64fed9d68a1bcb36c9736e4f80abf626f9).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4715][Core] Make sure tryToAcquire won'...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3575#issuecomment-65378009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24080/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4715][Core] Make sure tryToAcquire won'...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3575#issuecomment-65377998
[Test build #24080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24080/consoleFull) for PR 3575 at commit [`a193ae6`](https://github.com/apache/spark/commit/a193ae64fed9d68a1bcb36c9736e4f80abf626f9).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class NullType extends DataType `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org