You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2024/12/16 06:52:21 UTC
[PR] [SPARK-50586][BUILD] Use CommonJS format for ESLint configuration file [spark]
sarutak opened a new pull request, #49198:
URL: https://github.com/apache/spark/pull/49198
### What changes were proposed in this pull request?
This PR proposes to use CommonJS format for ESLint configuration file instead of JSON format.
### Why are the changes needed?
CommonJS format is just plain JavaScript so we can add comments to the configuration file.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Temporarily modified some `.js` files and ran `dev/lint-js`, then the linter detected violations.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50586][BUILD] Use CommonJS format for ESLint configuration file [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #49198: [SPARK-50586][BUILD] Use CommonJS format for ESLint configuration file
URL: https://github.com/apache/spark/pull/49198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50586][BUILD] Use CommonJS format for ESLint configuration file [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #49198:
URL: https://github.com/apache/spark/pull/49198#issuecomment-2555583909
+1, LGTM. Merging to master.
Thank you, @sarutak and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50586][BUILD] Use CommonJS format for ESLint configuration file [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #49198:
URL: https://github.com/apache/spark/pull/49198#issuecomment-2545143820
I don't think the CI failure is relevant to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org