[GitHub] [pinot] npawar commented on a diff in pull request #8539: Add brokerURL and better handle TimeoutException in QueryRunner

[GitBox <gi...@apache.org>]

npawar commented on code in PR #8539:
URL: https://github.com/apache/pinot/pull/8539#discussion_r849984702


##########
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java:
##########
@@ -299,50 +302,53 @@ public static QuerySummary singleThreadedQueryRunner(PerfBenchmarkDriverConf con
     long reportStartTime = startTime;
     int numReportIntervals = 0;
     int numTimesExecuted = 0;
-    while (numTimesToRunQueries == 0 || numTimesExecuted < numTimesToRunQueries) {
-      for (String query : queries) {
-        if (timeout > 0 && System.currentTimeMillis() - startTimeAbsolute > timeout) {
-          LOGGER.warn("Timeout of {} sec reached. Aborting", timeout);
-          throw new TimeoutException("Timeout of " + timeout + " sec reached. Aborting");
-        }
+    try {

Review Comment:
   there's no change here other than adding TimeoutException and catching it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org