You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/22 20:59:44 UTC

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request #14: [FLINK-26193] Commit generated CRD into Git repo

morhidi opened a new pull request #14:
URL: https://github.com/apache/flink-kubernetes-operator/pull/14


   - adding the CRD into Git repo to better track the schema changes and enable helm installs without compiling the source
   - picked `Method 1` from https://helm.sh/docs/chart_best_practices/custom_resource_definitions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on a change in pull request #14: [FLINK-26193] Commit generated CRD into Git repo

Posted by GitBox <gi...@apache.org>.
morhidi commented on a change in pull request #14:
URL: https://github.com/apache/flink-kubernetes-operator/pull/14#discussion_r812605055



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/FlinkDeploymentSpec.java
##########
@@ -41,5 +41,4 @@
     private JobManagerSpec jobManager;
     private TaskManagerSpec taskManager;
     private JobSpec job;
-    private Map<String, String> logging;

Review comment:
       yes, also we discussed it with @gyfora that map is not the ideal form here for the logging, we'll have to reintroduce it in another form to support log4j, logback.. configs




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #14: [FLINK-26193] Commit generated CRD into Git repo

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14:
URL: https://github.com/apache/flink-kubernetes-operator/pull/14#discussion_r812596447



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/FlinkDeploymentSpec.java
##########
@@ -41,5 +41,4 @@
     private JobManagerSpec jobManager;
     private TaskManagerSpec taskManager;
     private JobSpec job;
-    private Map<String, String> logging;

Review comment:
       Do we remove the `logging` field because it is not supported now?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #14: [FLINK-26193] Commit generated CRD into Git repo

Posted by GitBox <gi...@apache.org>.
morhidi commented on pull request #14:
URL: https://github.com/apache/flink-kubernetes-operator/pull/14#issuecomment-1048206671


   cc @gyfora @tweise @wangyang0918 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #14: [FLINK-26193] Commit generated CRD into Git repo

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #14:
URL: https://github.com/apache/flink-kubernetes-operator/pull/14#discussion_r812609402



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/FlinkDeploymentSpec.java
##########
@@ -41,5 +41,4 @@
     private JobManagerSpec jobManager;
     private TaskManagerSpec taskManager;
     private JobSpec job;
-    private Map<String, String> logging;

Review comment:
       Great.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #14: [FLINK-26193] Commit generated CRD into Git repo

Posted by GitBox <gi...@apache.org>.
wangyang0918 merged pull request #14:
URL: https://github.com/apache/flink-kubernetes-operator/pull/14


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org