You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2015/09/29 07:57:34 UTC
incubator-kylin git commit: KYLIN-1025 Save cube change is very slow
Repository: incubator-kylin
Updated Branches:
refs/heads/2.x-staging 5dd8ee18f -> 0a6e5b3f6
KYLIN-1025 Save cube change is very slow
Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/0a6e5b3f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/0a6e5b3f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/0a6e5b3f
Branch: refs/heads/2.x-staging
Commit: 0a6e5b3f6a3cc13e5e070621a5cc8af1d6b6ef08
Parents: 5dd8ee1
Author: shaofengshi <sh...@apache.org>
Authored: Tue Sep 29 13:57:04 2015 +0800
Committer: shaofengshi <sh...@apache.org>
Committed: Tue Sep 29 13:57:04 2015 +0800
----------------------------------------------------------------------
.../main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/0a6e5b3f/core-cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java
----------------------------------------------------------------------
diff --git a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java
index c6dc55a..7a4b00a 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java
@@ -64,15 +64,17 @@ public class CuboidCLI {
cuboidQueue.push(sc);
}
}
-
+
+ /** disable this due to poor performance when dimension number is big
TreeSet<Long> enumCuboids = enumCalcCuboidCount(cube);
if (enumCuboids.equals(cuboidSet) == false) {
throw new IllegalStateException("Expected cuboid set " + enumCuboids + "; but actual cuboid set " + cuboidSet);
}
+ */
int mathCount = mathCalcCuboidCount(cube);
- if (mathCount != enumCuboids.size()) {
- throw new IllegalStateException("Math cuboid count " + mathCount + ", but actual cuboid count " + enumCuboids.size());
+ if (mathCount != cuboidSet.size()) {
+ throw new IllegalStateException("Math cuboid count " + mathCount + ", but actual cuboid count " + cuboidSet.size());
}
return mathCount;