[jira] [Commented] (ARROW-1791) Integration tests generate date[DAY] values outside of reasonable range

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257848#comment-16257848 ] 

ASF GitHub Bot commented on ARROW-1791:
---------------------------------------

wesm opened a new pull request #1328: ARROW-1791: Limit generated data range to physical limits for temporal types
URL: https://github.com/apache/arrow/pull/1328
 
 
   cc @trxcllnt, do these time ranges seem reasonable?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Integration tests generate date[DAY] values outside of reasonable range
> -----------------------------------------------------------------------
>
>                 Key: ARROW-1791
>                 URL: https://issues.apache.org/jira/browse/ARROW-1791
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> The integration tests are generating random int32 values, but for systems that use millisecond-based date objects (like JavaScript), converting to millisecond date will cause an overflow in a lot of cases. We should generate values that are within a reasonable year range so that overflows when converting to milliseconds do not occur



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)