You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/10/22 02:12:11 UTC

[GitHub] [incubator-dolphinscheduler] huzekang opened a new pull request #3968: Improvement daemon script usage

huzekang opened a new pull request #3968:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3968


   Improvement daemon script usage .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] huzekang commented on pull request #3968: Improvement daemon script usage

Posted by GitBox <gi...@apache.org>.
huzekang commented on pull request #3968:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3968#issuecomment-714185672


   It is convenient to use dolphinscheduler-daemon.sh on the server


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #3968: Improvement daemon script usage

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3968:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3968#issuecomment-714178913


   # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968?src=pr&el=h1) Report
   > Merging [#3968](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/8fd3932bff374a03ef159bd2a2f495728c8e5d4e?el=desc) will **decrease** coverage by `0.79%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/graphs/tree.svg?width=650&height=150&src=pr&token=bv9iXXRLi9)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##                dev    #3968      +/-   ##
   ============================================
   - Coverage     40.14%   39.35%   -0.80%     
   + Complexity     2938     2888      -50     
   ============================================
     Files           460      460              
     Lines         21835    21835              
     Branches       2654     2654              
   ============================================
   - Hits           8766     8593     -173     
   - Misses        12240    12431     +191     
   + Partials        829      811      -18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...er/server/builder/TaskExecutionContextBuilder.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2J1aWxkZXIvVGFza0V4ZWN1dGlvbkNvbnRleHRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-10.00%)` | |
   | [...he/dolphinscheduler/common/enums/SqoopJobType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Nxb29wSm9iVHlwZS5qYXZh) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...e/dolphinscheduler/server/entity/TaskPriority.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9UYXNrUHJpb3JpdHkuamF2YQ==) | `0.00% <0.00%> (-44.45%)` | `0.00% <0.00%> (-3.00%)` | |
   | [...ver/master/consumer/TaskPriorityQueueConsumer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25zdW1lci9UYXNrUHJpb3JpdHlRdWV1ZUNvbnN1bWVyLmphdmE=) | `5.92% <0.00%> (-38.82%)` | `5.00% <0.00%> (-10.00%)` | |
   | [...rver/master/dispatch/context/ExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9jb250ZXh0L0V4ZWN1dGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...duler/server/entity/DataxTaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9EYXRheFRhc2tFeGVjdXRpb25Db250ZXh0LmphdmE=) | `65.00% <0.00%> (-30.00%)` | `7.00% <0.00%> (-6.00%)` | |
   | [...r/server/entity/ProcedureTaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9Qcm9jZWR1cmVUYXNrRXhlY3V0aW9uQ29udGV4dC5qYXZh) | `60.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (-1.00%)` | |
   | [.../server/master/runner/DependentTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvRGVwZW5kZW50VGFza0V4ZWNUaHJlYWQuamF2YQ==) | `53.26% <0.00%> (-17.40%)` | `10.00% <0.00%> (-5.00%)` | |
   | [...duler/server/entity/SqoopTaskExecutionContext.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL2VudGl0eS9TcW9vcFRhc2tFeGVjdXRpb25Db250ZXh0LmphdmE=) | `85.00% <0.00%> (-10.00%)` | `11.00% <0.00%> (-2.00%)` | |
   | [...olphinscheduler/server/utils/DependentExecute.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL0RlcGVuZGVudEV4ZWN1dGUuamF2YQ==) | `60.25% <0.00%> (-8.98%)` | `17.00% <0.00%> (-4.00%)` | |
   | ... and [8 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968?src=pr&el=footer). Last update [8fd3932...6f7c2dd](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/3968?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on a change in pull request #3968: [Improvement][script] daemon script usage

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on a change in pull request #3968:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3968#discussion_r512369823



##########
File path: script/dolphinscheduler-daemon.sh
##########
@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 
-usage="Usage: dolphinscheduler-daemon.sh (start|stop|status) <command> "
+usage="Usage: dolphinscheduler-daemon.sh (start|stop) <api-server|master-server|worker-server|alert-server> "

Review comment:
       There are other commands, please confirm.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on a change in pull request #3968: [Improvement][script] daemon script usage

Posted by GitBox <gi...@apache.org>.
zhuangchong commented on a change in pull request #3968:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3968#discussion_r512369096



##########
File path: script/dolphinscheduler-daemon.sh
##########
@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 
-usage="Usage: dolphinscheduler-daemon.sh (start|stop|status) <command> "
+usage="Usage: dolphinscheduler-daemon.sh (start|stop) <api-server|master-server|worker-server|alert-server> "

Review comment:
       Why remove status?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3968: Improvement daemon script usage

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3968:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3968#issuecomment-714179957


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
 ct/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3968&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3968&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3968&metric=duplicated_lines_density&view=list) No Duplication information
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org