You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Jon Weygandt (JIRA)" <ji...@apache.org> on 2009/10/19 18:38:00 UTC
[jira] Created: (SHINDIG-1199) OpenSocialI18NGadgetRewriter's
creation of JsLibrary should be consistent with JsFeatureLoader
OpenSocialI18NGadgetRewriter's creation of JsLibrary should be consistent with JsFeatureLoader
----------------------------------------------------------------------------------------------
Key: SHINDIG-1199
URL: https://issues.apache.org/jira/browse/SHINDIG-1199
Project: Shindig
Issue Type: Improvement
Components: Java
Affects Versions: 1.1-BETA3
Reporter: Jon Weygandt
Priority: Minor
Similar to johnh's patch to JsFeatureLoader of May 26, 2009, OpenSocialI18NGadgetRewriter needs to have the feature loader created in a similar, injectable, manner. Ref: http://fisheye6.atlassian.com/browse/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsFeatureLoader.java#r778905
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1199) OpenSocialI18NGadgetRewriter's
creation of JsLibrary should be consistent with JsFeatureLoader
Posted by "Jon Weygandt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Weygandt updated SHINDIG-1199:
----------------------------------
Attachment: fix-1199-bug-v2.patch
This patch file supersedes the previous one. This implements choice A from the appspot code review, using JsFeatureLoader as the injectable factory object.
> OpenSocialI18NGadgetRewriter's creation of JsLibrary should be consistent with JsFeatureLoader
> ----------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1199
> URL: https://issues.apache.org/jira/browse/SHINDIG-1199
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 1.1-BETA3
> Reporter: Jon Weygandt
> Priority: Minor
> Attachments: fix-1199-bug-v2.patch, fix-1199-bug.patch
>
>
> Similar to johnh's patch to JsFeatureLoader of May 26, 2009, OpenSocialI18NGadgetRewriter needs to have the feature loader created in a similar, injectable, manner. Ref: http://fisheye6.atlassian.com/browse/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsFeatureLoader.java#r778905
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1199) OpenSocialI18NGadgetRewriter's
creation of JsLibrary should be consistent with JsFeatureLoader
Posted by "Jon Weygandt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Weygandt updated SHINDIG-1199:
----------------------------------
Attachment: fix-1199-bug.patch
Code review: http://codereview.appspot.com/135048
> OpenSocialI18NGadgetRewriter's creation of JsLibrary should be consistent with JsFeatureLoader
> ----------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1199
> URL: https://issues.apache.org/jira/browse/SHINDIG-1199
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 1.1-BETA3
> Reporter: Jon Weygandt
> Priority: Minor
> Attachments: fix-1199-bug.patch
>
>
> Similar to johnh's patch to JsFeatureLoader of May 26, 2009, OpenSocialI18NGadgetRewriter needs to have the feature loader created in a similar, injectable, manner. Ref: http://fisheye6.atlassian.com/browse/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsFeatureLoader.java#r778905
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1199) OpenSocialI18NGadgetRewriter's
creation of JsLibrary should be consistent with JsFeatureLoader
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1199.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.1-BETA4
lgtm
> OpenSocialI18NGadgetRewriter's creation of JsLibrary should be consistent with JsFeatureLoader
> ----------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1199
> URL: https://issues.apache.org/jira/browse/SHINDIG-1199
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 1.1-BETA3
> Reporter: Jon Weygandt
> Priority: Minor
> Fix For: 1.1-BETA4
>
> Attachments: fix-1199-bug-v2.patch, fix-1199-bug.patch
>
>
> Similar to johnh's patch to JsFeatureLoader of May 26, 2009, OpenSocialI18NGadgetRewriter needs to have the feature loader created in a similar, injectable, manner. Ref: http://fisheye6.atlassian.com/browse/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsFeatureLoader.java#r778905
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.