You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ashwinpankaj (via GitHub)" <gi...@apache.org> on 2023/12/04 08:33:12 UTC
[PR] KAFKA-9545 Fix Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted` [kafka]
ashwinpankaj opened a new pull request, #14910:
URL: https://github.com/apache/kafka/pull/14910
RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted does not wait to ensure that test-topic-A is deleted. The second assignment condition times out in 15sec.
We should wait for default topic delete timeout of 30sec and then check the assignment.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-9545: Fix Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted` [kafka]
Posted by "ashwinpankaj (via GitHub)" <gi...@apache.org>.
ashwinpankaj commented on PR #14910:
URL: https://github.com/apache/kafka/pull/14910#issuecomment-1840012911
> LGTM
Thanks @wcarlson5 !! - can you please merge this commit ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-9545: Fix Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted` [kafka]
Posted by "wcarlson5 (via GitHub)" <gi...@apache.org>.
wcarlson5 commented on PR #14910:
URL: https://github.com/apache/kafka/pull/14910#issuecomment-1841261270
Yeah was just waiting for the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-9545: Fix Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted` [kafka]
Posted by "wcarlson5 (via GitHub)" <gi...@apache.org>.
wcarlson5 merged PR #14910:
URL: https://github.com/apache/kafka/pull/14910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-9545: Fix Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted` [kafka]
Posted by "cadonna (via GitHub)" <gi...@apache.org>.
cadonna commented on PR #14910:
URL: https://github.com/apache/kafka/pull/14910#issuecomment-1853437970
@wcarlson5 @ashwinpankaj This fix does not seem to unflake the test. If I run it multiple times locally I get a failure after a couple of runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-9545: Fix Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted` [kafka]
Posted by "ashwinpankaj (via GitHub)" <gi...@apache.org>.
ashwinpankaj commented on PR #14910:
URL: https://github.com/apache/kafka/pull/14910#issuecomment-1855076180
> @wcarlson5 @ashwinpankaj This fix does not seem to unflake the test. If I run it multiple times locally I get a failure after a couple of runs. I reopened the ticket.
ack - will take a look. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org