You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by "ilgrosso (via GitHub)" <gi...@apache.org> on 2026/01/28 15:13:08 UTC
[PR] Improvements and refactoring [syncope]
ilgrosso opened a new pull request, #1292:
URL: https://github.com/apache/syncope/pull/1292
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements and refactoring [syncope]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #1292:
URL: https://github.com/apache/syncope/pull/1292#discussion_r2737191696
##########
ext/opensearch/persistence/src/main/java/org/apache/syncope/core/persistence/opensearch/dao/OpenSearchAuditEventDAO.java:
##########
@@ -182,17 +179,15 @@
build();
LOG.debug("Search request: {}", request);
- List<Hit<ObjectNode>> esResult = null;
+ List<Hit<AuditEventTO>> osResult = null;
try {
- esResult = client.search(request, ObjectNode.class).hits().hits();
+ osResult = client.search(request, AuditEventTO.class).hits().hits();
} catch (Exception e) {
LOG.error("While searching in OpenSearch with request {}", request, e);
}
- return CollectionUtils.isEmpty(esResult)
+ return CollectionUtils.isEmpty(osResult)
? List.of()
- : esResult.stream().
- map(hit -> POJOHelper.convertValue(hit.source(), AuditEventTO.class)).
- filter(Objects::nonNull).toList();
+ : osResult.stream().map(Hit::source).toList();
Review Comment:
## Dereferenced variable may be null
Variable [osResult](1) may be null at this access because of [this](2) assignment.
[Show more details](https://github.com/apache/syncope/security/code-scanning/2511)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improvements and refactoring [syncope]
Posted by "ilgrosso (via GitHub)" <gi...@apache.org>.
ilgrosso merged PR #1292:
URL: https://github.com/apache/syncope/pull/1292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@syncope.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org