You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2025/03/05 01:09:35 UTC
(superset) branch elizabeth/fix-default-error updated (7ce1a3445c -> dc066845e8)
This is an automated email from the ASF dual-hosted git repository.
elizabeth pushed a change to branch elizabeth/fix-default-error
in repository https://gitbox.apache.org/repos/asf/superset.git
from 7ce1a3445c fix: oauth2 trino (#31993)
add c27aee2b14 chore(duckdb): Bump duckdb-engine, duckdb versions (#32302)
add f820f9a976 chore(build): remove Lodash filter and noop usage in `superset-frontend` (#32341)
add 422a07b382 fix: revert "fix: remove sort values on stacked totals (#31333)" (#32337)
add 88cf2d5c39 fix(fe/dashboard-list): display modifier info for `Last modified` data (#32035)
add 5140250421 ci(type-checking): run type-checking-frontend hook sequentially (#32323)
add b06a9edfd6 chore(docs): Fix typo in security.mdx (#32349)
add 2c37ddb2f6 fix(roles): Add SqlLabPermalinkRestApi as default sqlab roles. (#32284)
add 4c4b5e8c64 fix(SSHTunnelForm): make the password tooltip visible (#32356)
add ace8a3adb7 refactor(DatabaseSelector): Changes the imported types from antd-4 to antd-5 (#32314)
add 22fe985cfc fix(firebolt): allow backslach escape for single quotes (#32350)
add 0f07d78e01 fix(docker): Configure nginx for consistent port mapping and hot reloading (#32362)
add c583eec4c7 fix(eslint-hook): ensure eslint hook receives arguments (#32333)
add 90651dfe3e fix(dev/ci): pre-commit fixes galore (#32352)
add bc02f05613 feat(number-format): adds memory data transfer rates in binary and decimal format (#32264)
add b43e2ac8f4 chore(tests): converting enzyme to RTL, part 3 (#32363)
add 8dcae810d4 fix: clickhouse-connect engine SSH parameter (#32348)
add b0dac046e6 refactor(DrillDetailTableControls): Upgrade DrillDetailTableControls component to Ant Design 5 (#32313)
add 83071d0e5f fix: ensure metric_macro expands templates (#32344)
add 00883c395c feat: allow importing encrypted_extra (#32339)
add 167dacc2e4 fix: ephemeral CI fetching task ENI (#32377)
add 793fbac405 chore(cleanup): removing accidentally committed package/lock files. (#32365)
add 479a5d2f72 chore: Upgrade AG Grid to use tree shaking (#32334)
add a08c18febe docs(intro): broaden link to installation options (#32379)
add c02a0a00f4 fix: bump FAB to 4.5.4 (#32325)
add 822d72c57d fix(pinot): revert join and subquery flags (#32382)
add dae6acf028 chore(docs): update instructions for pypi distribution (#32380)
add 00429558c2 docs: add shipmnts to users list (#32396)
add 1d823a0be5 chore(docs): fix typos (#32393)
add 74733ae310 feat: Adding the option and feature to enable borders with color, opacity and width control on heatmaps along with white borders on emphasis (#32358)
add f4105e9ed2 feat: default ports for SSH tunnel (#32403)
add 2c851b7580 feat(i18n): Add polish to default language (#31506)
add cf7ce31054 build(deps): bump major versions for `math-expression-evaluator` and `fetch-mock` + clean up obsolete dev/override packages (#32322)
add 789049d386 docs(config): fill in commonly connection string for Oracle, Presto and SQL Server databases (#32385)
add 4d6b4f8343 feat(filter): adding inputs to Numerical Range Filter (#31726)
add 128c45e2d3 fix: prevent nested transactions (#32401)
add 6317a91541 fix(viz): update nesting logic to handle multiple dimensions in PartitionViz (#32290)
add eacb234872 docs: add SingleStore to the users list (#32421)
add 84b52b2323 fix(clickhouse): get_parameters_from_uri failing when secure is true (#32423)
add d79f7b28c2 feat: Update database permissions in async mode (#32231)
add 61b72f0c0b fix(com/grid-comp/markdown): pin `remark-gfm` to v3 to allow inline code block by backticks in Markdown (#32420)
add 5766c36372 fix(plugin-chart-echarts): remove erroneous upper bound value (#32473)
add 5af4e61aff feat: improve GSheets OAuth2 (#32048)
add 6c3886aad0 fix(tooltip): displaying <a> tags correctly (#32488)
add ce367d6427 chore(deps-dev): bump @docusaurus/tsconfig from 3.6.3 to 3.7.0 in /docs (#32087)
add d7e0ee6ceb fix(docker compose): replace port 8088 with 9000 (#32481)
add 2b98f326e8 feat: cache the frontend's bootstrap data (#31996)
add fe33661821 chore(deps-dev): bump typescript from 5.1.6 to 5.8.2 in /docs (#32452)
add 15cf06699a feat: security, user group support (#32121)
add 16b08e333d chore(deps-dev): bump webpack from 5.97.1 to 5.98.0 in /docs (#32449)
add a4902a3685 chore(deps): bump antd from 5.24.1 to 5.24.2 in /docs (#32447)
add 0d24ce0ef9 chore(deps-dev): bump @types/lodash from 4.17.14 to 4.17.16 in /superset-frontend (#32476)
add 93d759c689 chore(deps): bump swagger-ui-react from 5.19.0 to 5.20.0 in /docs (#32454)
add ef08ccbaa2 chore(deps-dev): bump @types/jsonwebtoken from 9.0.6 to 9.0.9 in /superset-websocket (#32440)
add c0e92b1639 feat(flag flip): Setting Horizontal Filters to True by default. (#32317)
add 813e79fa9f fix: skip DB filter when doing OAuth2 (#32486)
add 6173a6c329 chore(deps): bump chrono-node from 2.7.7 to 2.7.8 in /superset-frontend (#32462)
add 3d5128735b chore(deps): bump @rjsf/utils from 5.24.1 to 5.24.3 in /superset-frontend (#32461)
add a45ce1e8d1 chore(deps-dev): bump @babel/types from 7.26.7 to 7.26.9 in /superset-frontend (#32460)
add 807dcddc28 chore(deps): bump @deck.gl/react from 9.1.0 to 9.1.4 in /superset-frontend (#32453)
add 2b53b1800e chore: various markdown warnings resolved (#30657)
add 33370eaa5c chore: enable dependabot using uv for auto-bumping python packages (#32501)
add 90388885db chore(deps-dev): bump @typescript-eslint/eslint-plugin from 8.19.0 to 8.26.0 in /superset-websocket (#32503)
add d8686c2d12 chore(deps-dev): update @babel/types requirement from ^7.26.3 to ^7.26.9 in /superset-frontend/plugins/plugin-chart-pivot-table (#32470)
new dc066845e8 fix default error
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.github/dependabot.yml | 16 +-
.github/workflows/ephemeral-env.yml | 2 +-
.github/workflows/pre-commit.yml | 19 +-
.pre-commit-config.yaml | 47 +-
README.md | 2 +-
RELEASING/README.md | 5 +-
RELEASING/changelog.py | 11 +-
RESOURCES/FEATURE_FLAGS.md | 1 -
RESOURCES/INTHEWILD.md | 18 +-
UPDATING.md | 1 +
docker-compose.yml | 2 +-
docker/nginx/nginx.conf | 6 +
docker/pythonpath_dev/superset_config.py | 2 +-
.../webpack.config.js => docs/.eslintrc.js | 52 +-
docs/babel.config.js | 1 +
docs/docs/configuration/alerts-reports.mdx | 7 +-
docs/docs/configuration/async-queries-celery.mdx | 8 +-
docs/docs/configuration/cache.mdx | 4 +-
docs/docs/configuration/configuring-superset.mdx | 19 +-
docs/docs/configuration/databases.mdx | 157 +-
.../importing-exporting-datasources.mdx | 22 +-
docs/docs/configuration/networking-settings.mdx | 11 +-
docs/docs/configuration/sql-templating.mdx | 21 +-
docs/docs/configuration/timezones.mdx | 4 +-
docs/docs/contributing/development.mdx | 23 +-
docs/docs/contributing/resources.mdx | 2 +-
docs/docs/faq.mdx | 20 +-
docs/docs/installation/architecture.mdx | 4 +
docs/docs/installation/docker-builds.mdx | 3 +-
docs/docs/installation/kubernetes.mdx | 1 +
docs/docs/quickstart.mdx | 4 +-
docs/docs/security/security.mdx | 13 +-
.../creating-your-first-dashboard.mdx | 6 +-
docs/docs/using-superset/exploring-data.mdx | 2 +-
docs/docusaurus.config.ts | 181 +-
docs/package.json | 20 +-
docs/sidebars.js | 52 +-
docs/src/components/SectionHeader.tsx | 2 +-
docs/src/pages/community.tsx | 20 +-
docs/src/pages/index.tsx | 8 +-
docs/src/theme/DocItem/index.js | 12 +-
docs/src/utils.js | 2 +-
docs/static/script/matomo.js | 1 +
docs/yarn.lock | 4339 +++++----
pyproject.toml | 4 +-
requirements/base.txt | 2 +-
requirements/development.txt | 2 +-
scripts/cancel_github_workflows.py | 2 +-
.../entrypoints/docker-ci.sh => scripts/eslint.sh | 20 +-
.../dashboard/nativeFilters.noInitState.test.ts | 38 +-
.../cypress-base/cypress/e2e/dashboard/utils.ts | 2 +-
superset-frontend/jest.config.js | 2 +-
superset-frontend/package-lock.json | 1171 ++-
superset-frontend/package.json | 31 +-
.../src/utils/D3Formatting.ts | 8 +
.../packages/superset-ui-core/package.json | 6 +-
.../superset-ui-core/src/math-expression/index.ts | 4 +-
.../factories/createMemoryFormatter.ts | 61 +-
.../superset-ui-core/src/query/getMetricLabel.ts | 24 +-
.../superset-ui-core/src/utils/featureFlags.ts | 1 -
.../factories/createMemoryFormatter.test.ts | 48 +
.../test/time-comparison/fetchTimeRange.test.ts | 2 +-
.../shared/components/ResizableChartDemo.tsx | 17 +-
.../storybook/shared/components/ResizablePanel.tsx | 4 +-
.../LegacyPluginChartChord.stories.tsx | 2 +-
.../CountryMap.stories.tsx | 16 +-
.../BoxPlot/NVD3BoxPlot.stories.tsx | 4 +-
.../plugin-chart-echarts/Gauge/Gauge.stories.tsx | 2 +-
.../plugin-chart-echarts/Graph/Graph.stories.tsx | 2 +-
.../plugin-chart-echarts/Radar/Radar.stories.tsx | 2 +-
.../Timeseries/Timeseries.stories.tsx | 16 +-
.../Waterfall/Waterfall.stories.tsx | 8 +-
.../PivotTable.stories.tsx | 10 +-
.../plugins/plugin-chart-table/Table.stories.tsx | 2 +-
.../stories/plugins/plugin-chart-table/testData.ts | 6 +-
.../stories/superset-ui-color/RenderPalettes.tsx | 16 +-
.../NumberFormat.stories.tsx | 16 +-
.../stories/superset-ui-style/Theme.stories.tsx | 11 +-
.../superset-ui-time-format/TimeFormat.stories.tsx | 19 +-
.../legacy-preset-chart-deckgl/package.json | 2 +-
.../src/layers/Screengrid/Screengrid.tsx | 3 +-
.../src/Heatmap/controlPanel.tsx | 25 +
.../src/Heatmap/transformProps.ts | 19 +
.../plugin-chart-echarts/src/Heatmap/types.ts | 3 +
.../src/MixedTimeseries/transformProps.ts | 13 +-
.../src/Timeseries/transformProps.ts | 7 +-
.../src/Timeseries/transformers.ts | 11 +-
.../src/utils/eventHandlers.ts | 3 +-
.../plugin-chart-echarts/src/utils/series.ts | 6 +-
.../test/Timeseries/transformProps.test.ts | 34 +-
.../plugin-chart-echarts/test/utils/series.test.ts | 118 -
.../plugins/plugin-chart-handlebars/package.json | 2 +-
.../plugins/plugin-chart-pivot-table/package.json | 2 +-
.../src/plugin/controlPanel.tsx | 2 +-
.../plugin-chart-table/src/controlPanel.tsx | 2 +-
.../src/SqlLab/actions/sqlLab.test.js | 4 +-
.../SqlLab/components/ResultSet/ResultSet.test.tsx | 19 +-
.../ShareSqlLabQuery/ShareSqlLabQuery.test.tsx | 2 +-
.../components/TableElement/TableElement.test.tsx | 2 +-
.../src/components/AuditInfo/ModifiedInfo.test.tsx | 2 +-
superset-frontend/src/components/Chart/Chart.tsx | 10 +-
.../Chart/DrillBy/DrillByMenuItems.test.tsx | 4 +-
.../DrillDetailTableControls.stories.tsx} | 22 +-
.../DrillDetail/DrillDetailTableControls.test.tsx | 3 +-
.../Chart/DrillDetail/DrillDetailTableControls.tsx | 37 +-
.../src/components/Chart/chartActions.test.js | 2 +-
.../src/components/DatabaseSelector/index.tsx | 2 +-
.../FilterableTable/FilterableTable.test.tsx | 21 +-
.../src/components/Form/LabeledErrorBoundInput.tsx | 3 +-
.../src/components/GridTable/GridTable.test.tsx | 5 +
.../src/components/GridTable/HeaderMenu.test.tsx | 2 +-
.../src/components/GridTable/index.tsx | 43 +-
.../cell-renderers/NullCell => Metadata}/index.tsx | 29 +-
superset-frontend/src/components/Tags/Tag.tsx | 21 +-
superset-frontend/src/dashboard/actions/hydrate.js | 5 +-
.../DashboardBuilder/DashboardBuilder.tsx | 7 +-
.../SliceHeaderControls.test.tsx | 2 +-
.../components/gridComponents/Header.test.jsx | 79 +-
.../FilterBar/ActionButtons/ActionButtons.test.tsx | 11 +-
.../FilterBarSettings/FilterBarSettings.test.tsx | 31 +-
.../FilterBar/FilterBarSettings/index.tsx | 19 +-
.../FilterBar/FilterControls/FilterControls.tsx | 7 +-
.../FilterBar/FilterControls/FilterValue.tsx | 2 +-
.../components/nativeFilters/FilterBar/utils.ts | 8 +
.../FiltersConfigForm/FiltersConfigForm.tsx | 2 +-
.../FiltersConfigModal/FiltersConfigModal.test.tsx | 3 +-
.../src/explore/actions/datasourcesActions.ts | 13 +-
.../DataTablesPane/test/DataTablesPane.test.tsx | 3 +-
.../PropertiesModal/PropertiesModal.test.tsx | 4 +-
.../AnnotationLayer.test.tsx | 2 +-
.../DndColumnSelect.test.tsx | 2 +-
.../OptionControls/OptionControls.test.tsx | 2 +-
.../DashboardsSubMenu.test.tsx | 2 +-
.../DatabaseConnectionForm/EncryptedField.tsx | 66 +-
.../OAuth2ClientField.test.tsx | 11 +-
.../DatabaseConnectionForm/OAuth2ClientField.tsx | 41 +-
.../DatabaseConnectionForm/TableCatalog.tsx | 9 +-
.../DatabaseConnectionForm/constants.ts | 6 +-
.../databases/DatabaseModal/SSHTunnelForm.tsx | 10 +-
.../src/features/databases/DatabaseModal/styles.ts | 25 +-
.../UploadDataModel/UploadDataModal.test.tsx | 7 +-
superset-frontend/src/features/databases/types.ts | 2 +-
superset-frontend/src/features/home/ChartTable.tsx | 3 +-
.../src/features/home/DashboardTable.tsx | 6 +-
.../src/features/home/RightMenu.test.tsx | 4 +-
.../features/rls/RowLevelSecurityModal.test.tsx | 6 +-
.../components/Range/RangeFilterPlugin.test.tsx | 86 +-
.../filters/components/Range/RangeFilterPlugin.tsx | 500 +-
.../src/middleware/asyncEvent.test.ts | 2 +-
.../pages/AlertReportList/AlertReportList.test.jsx | 208 +-
.../AnnotationLayerList.test.jsx | 180 +-
.../src/pages/ChartList/ChartList.test.jsx | 321 +-
.../pages/CssTemplateList/CssTemplateList.test.jsx | 181 +-
.../src/pages/DashboardList/DashboardList.test.jsx | 286 +-
.../src/pages/DashboardList/index.tsx | 5 +-
superset-frontend/src/pages/DatabaseList/index.tsx | 61 +
superset-frontend/src/pages/Home/Home.test.tsx | 2 +-
.../pages/SavedQueryList/SavedQueryList.test.jsx | 471 +-
superset-frontend/src/setup/setupAGGridModules.ts | 61 +
superset-frontend/src/setup/setupFormatters.ts | 10 +-
superset-frontend/src/types/TagType.ts | 1 +
.../react-syntax-highlighter.d.ts} | 29 +-
superset-frontend/src/utils/getBootstrapData.ts | 15 +-
superset-frontend/src/views/App.tsx | 2 +
superset-websocket/package-lock.json | 659 +-
superset-websocket/package.json | 4 +-
superset/charts/api.py | 6 +-
superset/charts/schemas.py | 3 +-
superset/cli/thumbnails.py | 2 +-
superset/commands/database/exceptions.py | 10 +
superset/commands/database/ssh_tunnel/create.py | 5 +-
superset/commands/database/ssh_tunnel/update.py | 5 +-
superset/commands/database/sync_permissions.py | 344 +
superset/commands/database/test_connection.py | 18 +-
superset/commands/database/update.py | 211 +-
superset/commands/database/utils.py | 92 +
superset/commands/database/validate.py | 2 +-
superset/common/db_query_status.py | 16 +-
superset/config.py | 11 +-
superset/connectors/sqla/models.py | 2 +-
superset/constants.py | 1 +
superset/dashboards/api.py | 3 +-
superset/dashboards/schemas.py | 3 +-
superset/databases/api.py | 70 +-
superset/databases/schemas.py | 8 +-
superset/datasets/api.py | 9 +-
superset/db_engine_specs/base.py | 5 +-
superset/db_engine_specs/clickhouse.py | 24 +-
superset/db_engine_specs/couchbase.py | 2 +-
superset/db_engine_specs/databricks.py | 5 +-
superset/db_engine_specs/duckdb.py | 2 +-
superset/db_engine_specs/gsheets.py | 42 +-
superset/db_engine_specs/hana.py | 5 +-
superset/db_engine_specs/hive.py | 5 +-
superset/db_engine_specs/oracle.py | 5 +-
superset/db_engine_specs/pinot.py | 2 +
superset/db_engine_specs/presto.py | 2 +-
superset/db_engine_specs/snowflake.py | 2 +-
superset/extensions/ssh.py | 5 +-
superset/jinja_context.py | 61 +-
superset/migrations/shared/utils.py | 4 +-
...b56500de1855_add_uuid_column_to_import_mixin.py | 2 +-
...14-38_a9422eeaae74_new_dataset_models_take_2.py | 10 +-
superset/models/core.py | 11 +-
superset/queries/api.py | 3 +-
superset/security/guest_token.py | 3 +-
superset/security/manager.py | 34 +-
superset/sql/dialects/firebolt.py | 5 +-
superset/sql_lab.py | 2 +-
superset/sqllab/api.py | 11 +-
superset/sqllab/sql_json_executer.py | 1 -
superset/tags/api.py | 7 +-
.../{zh => pl}/LC_MESSAGES/messages.po | 9464 +++++++++++---------
superset/utils/core.py | 16 +-
superset/utils/decorators.py | 7 +
superset/utils/pandas_postprocessing/histogram.py | 2 +-
superset/utils/ssh_tunnel.py | 14 +
superset/views/base.py | 1 +
superset/views/utils.py | 4 +-
superset/viz.py | 13 +-
tests/conftest.py | 35 +-
tests/integration_tests/base_api_tests.py | 2 +-
tests/integration_tests/celery_tests.py | 14 +-
tests/integration_tests/charts/commands_tests.py | 6 +-
tests/integration_tests/conftest.py | 34 +-
tests/integration_tests/core_tests.py | 2 +-
tests/integration_tests/dashboards/api_tests.py | 45 +-
tests/integration_tests/databases/api_tests.py | 510 +-
.../integration_tests/databases/commands_tests.py | 10 +-
tests/integration_tests/datasets/api_tests.py | 4 +-
tests/integration_tests/datasource_tests.py | 2 +-
.../db_engine_specs/base_engine_spec_tests.py | 3 +-
tests/integration_tests/fixtures/users.py | 80 +
.../7e67aecbf3f1_chart_ds_constraint__tests.py | 2 +-
.../fb13d49b72f9_better_filters__tests.py | 2 +-
tests/integration_tests/reports/scheduler_tests.py | 4 +-
tests/integration_tests/security/api_tests.py | 2 +-
.../security/row_level_security_tests.py | 1 -
tests/integration_tests/security_tests.py | 55 +-
tests/integration_tests/sql_lab/commands_tests.py | 11 +-
.../sql_lab/permalink/api_tests.py | 22 +
tests/integration_tests/sqllab_tests.py | 96 +-
tests/integration_tests/superset_test_config.py | 1 -
tests/integration_tests/tags/api_tests.py | 2 +-
tests/integration_tests/users/api_tests.py | 3 +-
tests/integration_tests/viz_tests.py | 21 +
tests/unit_tests/commands/databases/conftest.py | 90 +
.../commands/databases/excel_reader_test.py | 2 +-
.../commands/databases/importers}/__init__.py | 0
.../commands/databases/importers/v1}/__init__.py | 0
.../databases/importers/v1/command_test.py | 50 +
.../commands/databases/sync_permissions_test.py | 389 +
tests/unit_tests/commands/databases/update_test.py | 367 +-
tests/unit_tests/commands/databases/utils_test.py | 212 +
.../unit_tests/commands/databases/validate_test.py | 1 +
tests/unit_tests/connectors/sqla/models_test.py | 11 +-
tests/unit_tests/databases/api_test.py | 144 +
.../databases/ssh_tunnel/commands/create_test.py | 57 +-
.../databases/ssh_tunnel/commands/update_test.py | 31 +
tests/unit_tests/datasets/api_tests.py | 3 +-
tests/unit_tests/datasets/commands/export_test.py | 2 +-
tests/unit_tests/db_engine_specs/test_gsheets.py | 134 +-
tests/unit_tests/db_engine_specs/test_mssql.py | 47 +-
tests/unit_tests/db_engine_specs/test_ocient.py | 6 +-
tests/unit_tests/fixtures/dataframes.py | 4 +-
tests/unit_tests/jinja_context_test.py | 157 +-
.../unit_tests/migrations/shared/catalogs_test.py | 29 +-
tests/unit_tests/sql/parse_tests.py | 21 +
tests/unit_tests/utils/test_decorators.py | 53 +
269 files changed, 14700 insertions(+), 9384 deletions(-)
copy superset-embedded-sdk/webpack.config.js => docs/.eslintrc.js (55%)
copy docker/entrypoints/docker-ci.sh => scripts/eslint.sh (71%)
copy superset-frontend/src/{visualizations/dashboardComponents/ExampleComponent/index.ts => components/Chart/DrillDetail/DrillDetailTableControls.stories.tsx} (67%)
copy superset-frontend/src/components/{Table/cell-renderers/NullCell => Metadata}/index.tsx (62%)
create mode 100644 superset-frontend/src/setup/setupAGGridModules.ts
copy superset-frontend/src/{dashboard/components/nativeFilters/FilterCard/types.ts => types/react-syntax-highlighter.d.ts} (60%)
create mode 100644 superset/commands/database/sync_permissions.py
copy superset/translations/{zh => pl}/LC_MESSAGES/messages.po (50%)
create mode 100644 tests/unit_tests/commands/databases/conftest.py
copy {superset/advanced_data_type => tests/unit_tests/commands/databases/importers}/__init__.py (100%)
copy {superset/advanced_data_type => tests/unit_tests/commands/databases/importers/v1}/__init__.py (100%)
create mode 100644 tests/unit_tests/commands/databases/importers/v1/command_test.py
create mode 100644 tests/unit_tests/commands/databases/sync_permissions_test.py
create mode 100644 tests/unit_tests/commands/databases/utils_test.py
(superset) 01/01: fix default error
Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
elizabeth pushed a commit to branch elizabeth/fix-default-error
in repository https://gitbox.apache.org/repos/asf/superset.git
commit dc066845e8d2d669e255c6878e52f930d699aad9
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Tue Mar 4 17:07:18 2025 -0800
fix default error
---
superset-frontend/src/components/Chart/Chart.tsx | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/superset-frontend/src/components/Chart/Chart.tsx b/superset-frontend/src/components/Chart/Chart.tsx
index 0389ebd309..aa1c8cf25d 100644
--- a/superset-frontend/src/components/Chart/Chart.tsx
+++ b/superset-frontend/src/components/Chart/Chart.tsx
@@ -240,15 +240,7 @@ class Chart extends PureComponent<ChartProps, {}> {
height,
datasetsStatus,
} = this.props;
- let error = queryResponse?.errors?.[0];
- if (error === undefined) {
- error = {
- error_type: ErrorTypeEnum.FRONTEND_NETWORK_ERROR,
- level: 'error',
- message: t('Check your network connection'),
- extra: null,
- };
- }
+ const error = queryResponse?.errors?.[0];
const message = chartAlert || queryResponse?.message;
// if datasource is still loading, don't render JS errors