You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/05 14:11:50 UTC
[GitHub] [shardingsphere] yx9o opened a new pull request, #23363: Refactor ifNotExists of DB_DISCOVERY RULE.
yx9o opened a new pull request, #23363:
URL: https://github.com/apache/shardingsphere/pull/23363
For #22844 , refactor ifNotExists of DB_DISCOVERY RULE.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #23363: Refactor ifNotExists of DB_DISCOVERY RULE.
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #23363:
URL: https://github.com/apache/shardingsphere/pull/23363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23363: Refactor ifNotExists of DB_DISCOVERY RULE.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23363:
URL: https://github.com/apache/shardingsphere/pull/23363#issuecomment-1372306790
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23363](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75c6e54) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a97c7e60fac1abc5609ab212fcdf479f29d8cc43?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a97c7e6) will **increase** coverage by `0.01%`.
> The diff coverage is `95.00%`.
```diff
@@ Coverage Diff @@
## master #23363 +/- ##
============================================
+ Coverage 49.78% 49.80% +0.01%
Complexity 2458 2458
============================================
Files 4048 4048
Lines 58169 58177 +8
Branches 9237 9239 +2
============================================
+ Hits 28962 28974 +12
+ Misses 26652 26648 -4
Partials 2555 2555
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nager/standalone/StandaloneModeContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL3N0YW5kYWxvbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9tYW5hZ2VyL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1vZGVDb250ZXh0TWFuYWdlci5qYXZh) | `2.00% <0.00%> (+0.03%)` | :arrow_up: |
| [...e/CreateDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9DcmVhdGVEYXRhYmFzZURpc2NvdmVyeVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `93.02% <100.00%> (+2.28%)` | :arrow_up: |
| [...he/shardingsphere/mode/manager/ContextManager.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvQ29udGV4dE1hbmFnZXIuamF2YQ==) | `56.08% <100.00%> (+1.16%)` | :arrow_up: |
| [.../yaml/swapper/YamlPluginsConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9zd2FwcGVyL1lhbWxQbHVnaW5zQ29uZmlndXJhdGlvblN3YXBwZXIuamF2YQ==) | | |
| [...yaml/swapper/YamlPointcutConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9zd2FwcGVyL1lhbWxQb2ludGN1dENvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | | |
| [.../plugin/yaml/entity/YamlPointcutConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9lbnRpdHkvWWFtbFBvaW50Y3V0Q29uZmlndXJhdGlvbi5qYXZh) | | |
| [...yaml/swapper/YamlAdvisorsConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9zd2FwcGVyL1lhbWxBZHZpc29yc0NvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | | |
| [...re/config/yaml/entity/YamlPluginConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9jb25maWcveWFtbC9lbnRpdHkvWWFtbFBsdWdpbkNvbmZpZ3VyYXRpb24uamF2YQ==) | | |
| [...e/plugin/yaml/entity/YamlAdvisorConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9lbnRpdHkvWWFtbEFkdmlzb3JDb25maWd1cmF0aW9uLmphdmE=) | | |
| [.../plugin/yaml/entity/YamlAdvisorsConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9lbnRpdHkvWWFtbEFkdmlzb3JzQ29uZmlndXJhdGlvbi5qYXZh) | | |
| ... and [24 more](https://codecov.io/gh/apache/shardingsphere/pull/23363?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org