You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2017/04/21 03:15:19 UTC
[1/2] git commit: [flex-falcon] [refs/heads/develop] - accept
toString always. JS compiles don't have it defined on Object because then
int.toString(radix) reports an illegal override
Repository: flex-falcon
Updated Branches:
refs/heads/develop 5ffbc255a -> 153b51e24
accept toString always. JS compiles don't have it defined on Object because then int.toString(radix) reports an illegal override
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/27aa1dc0
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/27aa1dc0
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/27aa1dc0
Branch: refs/heads/develop
Commit: 27aa1dc0776e925f834f59ef9be91a0427ed167c
Parents: 5ffbc25
Author: Alex Harui <ah...@apache.org>
Authored: Thu Apr 20 19:51:12 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Thu Apr 20 19:51:12 2017 -0700
----------------------------------------------------------------------
.../internal/semantics/MethodBodySemanticChecker.java | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/27aa1dc0/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java
----------------------------------------------------------------------
diff --git a/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java b/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java
index 3904823..a20d4de 100644
--- a/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java
+++ b/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java
@@ -828,11 +828,12 @@ public class MethodBodySemanticChecker
{
if ( utils.isInaccessible(iNode, method_binding) )
{
- addProblem(new InaccessibleMethodReferenceProblem(
- roundUpUsualSuspects(method_binding, iNode),
- method_binding.getName().getBaseName(),
- utils.getTypeOfStem(iNode)
- ));
+ if (!method_binding.getName().getBaseName().equals("toString"))
+ addProblem(new InaccessibleMethodReferenceProblem(
+ roundUpUsualSuspects(method_binding, iNode),
+ method_binding.getName().getBaseName(),
+ utils.getTypeOfStem(iNode)
+ ));
}
else if ( SemanticUtils.hasExplicitStem(iNode) && utils.hasUnderlyingType(iNode) )
{
[2/2] git commit: [flex-falcon] [refs/heads/develop] - keep native
classes out of static dependency list
Posted by ah...@apache.org.
keep native classes out of static dependency list
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/153b51e2
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/153b51e2
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/153b51e2
Branch: refs/heads/develop
Commit: 153b51e24caa89e04e913d98e8e633f772247053
Parents: 27aa1dc
Author: Alex Harui <ah...@apache.org>
Authored: Thu Apr 20 20:12:57 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Thu Apr 20 20:12:57 2017 -0700
----------------------------------------------------------------------
.../flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/153b51e2/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java
index 2c2050a..897408f 100644
--- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java
+++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java
@@ -548,7 +548,7 @@ public class JSFlexJSEmitter extends JSGoogEmitter implements IJSFlexJSEmitter
else if (!isDoc)
{
if (getModel().inStaticInitializer)
- if (!staticUsedNames.contains(name))
+ if (!staticUsedNames.contains(name) && !NativeUtils.isJSNative(name))
staticUsedNames.add(name);
if (!usedNames.contains(name))