You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (JIRA)" <ji...@apache.org> on 2012/10/30 06:08:12 UTC
[jira] [Created] (HBASE-7069) HTable.batch does not have to
synchronized
Lars Hofhansl created HBASE-7069:
------------------------------------
Summary: HTable.batch does not have to synchronized
Key: HBASE-7069
URL: https://issues.apache.org/jira/browse/HBASE-7069
Project: HBase
Issue Type: Bug
Reporter: Lars Hofhansl
Assignee: Lars Hofhansl
Priority: Critical
Fix For: 0.94.3
This was raised on the mailing list by Yousuf.
HTable.batch(...) is synchronized and there appears to be no reason for it.
(flushCommits makes the same call to connection.processBatch and it also is not synchronized)
This is pretty bad actually marking critical.
0.96 is fine BTW.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7069) HTable.batch does not have to
synchronized
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490397#comment-13490397 ]
Hudson commented on HBASE-7069:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/])
HBASE-7069 (Revision 1403808)
Result = FAILURE
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTable.java
> HTable.batch does not have to synchronized
> ------------------------------------------
>
> Key: HBASE-7069
> URL: https://issues.apache.org/jira/browse/HBASE-7069
> Project: HBase
> Issue Type: Bug
> Components: Performance
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Critical
> Fix For: 0.94.3
>
> Attachments: 7069.txt
>
>
> This was raised on the mailing list by Yousuf.
> HTable.batch(...) is synchronized and there appears to be no reason for it.
> (flushCommits makes the same call to connection.processBatch and it also is not synchronized)
> This is pretty bad actually marking critical.
> 0.96 is fine BTW.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7069) HTable.batch does not have to
synchronized
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7069:
---------------------------------
Component/s: Performance
> HTable.batch does not have to synchronized
> ------------------------------------------
>
> Key: HBASE-7069
> URL: https://issues.apache.org/jira/browse/HBASE-7069
> Project: HBase
> Issue Type: Bug
> Components: Performance
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Critical
> Fix For: 0.94.3
>
>
> This was raised on the mailing list by Yousuf.
> HTable.batch(...) is synchronized and there appears to be no reason for it.
> (flushCommits makes the same call to connection.processBatch and it also is not synchronized)
> This is pretty bad actually marking critical.
> 0.96 is fine BTW.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7069) HTable.batch does not have to
synchronized
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486664#comment-13486664 ]
Ted Yu commented on HBASE-7069:
-------------------------------
+1 on patch.
> HTable.batch does not have to synchronized
> ------------------------------------------
>
> Key: HBASE-7069
> URL: https://issues.apache.org/jira/browse/HBASE-7069
> Project: HBase
> Issue Type: Bug
> Components: Performance
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Critical
> Fix For: 0.94.3
>
> Attachments: 7069.txt
>
>
> This was raised on the mailing list by Yousuf.
> HTable.batch(...) is synchronized and there appears to be no reason for it.
> (flushCommits makes the same call to connection.processBatch and it also is not synchronized)
> This is pretty bad actually marking critical.
> 0.96 is fine BTW.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7069) HTable.batch does not have to be
synchronized
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7069:
---------------------------------
Summary: HTable.batch does not have to be synchronized (was: HTable.batch does not have to synchronized)
> HTable.batch does not have to be synchronized
> ---------------------------------------------
>
> Key: HBASE-7069
> URL: https://issues.apache.org/jira/browse/HBASE-7069
> Project: HBase
> Issue Type: Bug
> Components: Performance
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Critical
> Fix For: 0.94.3
>
> Attachments: 7069.txt
>
>
> This was raised on the mailing list by Yousuf.
> HTable.batch(...) is synchronized and there appears to be no reason for it.
> (flushCommits makes the same call to connection.processBatch and it also is not synchronized)
> This is pretty bad actually marking critical.
> 0.96 is fine BTW.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-7069) HTable.batch does not have to
synchronized
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-7069:
---------------------------------
Attachment: 7069.txt
Trivial patch.
I looked through the code in HConnectionImplementation.processBatch, this really does not need to be synchronized here.
> HTable.batch does not have to synchronized
> ------------------------------------------
>
> Key: HBASE-7069
> URL: https://issues.apache.org/jira/browse/HBASE-7069
> Project: HBase
> Issue Type: Bug
> Components: Performance
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Critical
> Fix For: 0.94.3
>
> Attachments: 7069.txt
>
>
> This was raised on the mailing list by Yousuf.
> HTable.batch(...) is synchronized and there appears to be no reason for it.
> (flushCommits makes the same call to connection.processBatch and it also is not synchronized)
> This is pretty bad actually marking critical.
> 0.96 is fine BTW.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-7069) HTable.batch does not have to
synchronized
Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl resolved HBASE-7069.
----------------------------------
Resolution: Fixed
Committed to 0.94
> HTable.batch does not have to synchronized
> ------------------------------------------
>
> Key: HBASE-7069
> URL: https://issues.apache.org/jira/browse/HBASE-7069
> Project: HBase
> Issue Type: Bug
> Components: Performance
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Critical
> Fix For: 0.94.3
>
> Attachments: 7069.txt
>
>
> This was raised on the mailing list by Yousuf.
> HTable.batch(...) is synchronized and there appears to be no reason for it.
> (flushCommits makes the same call to connection.processBatch and it also is not synchronized)
> This is pretty bad actually marking critical.
> 0.96 is fine BTW.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7069) HTable.batch does not have to
synchronized
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-7069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487272#comment-13487272 ]
Hudson commented on HBASE-7069:
-------------------------------
Integrated in HBase-0.94 #560 (See [https://builds.apache.org/job/HBase-0.94/560/])
HBASE-7069 (Revision 1403808)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTable.java
> HTable.batch does not have to synchronized
> ------------------------------------------
>
> Key: HBASE-7069
> URL: https://issues.apache.org/jira/browse/HBASE-7069
> Project: HBase
> Issue Type: Bug
> Components: Performance
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Priority: Critical
> Fix For: 0.94.3
>
> Attachments: 7069.txt
>
>
> This was raised on the mailing list by Yousuf.
> HTable.batch(...) is synchronized and there appears to be no reason for it.
> (flushCommits makes the same call to connection.processBatch and it also is not synchronized)
> This is pretty bad actually marking critical.
> 0.96 is fine BTW.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira