You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/06/27 05:07:00 UTC
[jira] [Work logged] (GOBBLIN-1847) HelixException from the Job manager in Fast Ingest should try to delete the existing workflow
[ https://issues.apache.org/jira/browse/GOBBLIN-1847?focusedWorklogId=867641&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-867641 ]
ASF GitHub Bot logged work on GOBBLIN-1847:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/23 05:06
Start Date: 27/Jun/23 05:06
Worklog Time Spent: 10m
Work Description: homatthew opened a new pull request, #3711:
URL: https://github.com/apache/gobblin/pull/3711
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-1847] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1847
### Description
- [X] Here are some details about my PR, including screenshots (if applicable):
If the JobLauncher encounters any errors, Gobblin code cleans up the working directory that contains Gobblin state. But we do not clean up the helix workflows. This can cause us to spin up helix workflows that do not have valid Gobblin State on HDFS / S3.
When this occurs, it causes rapid container recycling, which puts tremendous load on Zookeeper due to Helix API calls, causing a peak in ZK callbacks
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 867641)
Remaining Estimate: 0h
Time Spent: 10m
> HelixException from the Job manager in Fast Ingest should try to delete the existing workflow
> ---------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1847
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1847
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)