You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/05 23:20:59 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #9893: ARROW-11766: [R] Better handling for missing compression codecs on Linux

jonkeane commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r607388600



##########
File path: r/tests/testthat/test-feather.R
##########
@@ -196,3 +196,17 @@ test_that("Character vectors > 2GB can write to feather", {
 })
 
 unlink(feather_file)
+
+ft_file <- test_path("golden-files/data-arrow_2.0.0_lz4.feather")
+

Review comment:
       In chatting with Neal about this, I had originally commented on the parquet test you added in the first PR that it wasn't being triggered. It wasn't ever triggered on the crossbow job that you were testing on that PR, but it turns out that that branch will be triggered in a different crossbow test that I had forgotten about: https://github.com/apache/arrow/blob/master/dev/tasks/tasks.yml#L1609-L1613. SO you'll want to run both of those crossbow builds when you're testing this to ensure that you're getting the messages you expect.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org