You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "cuibo01 (via GitHub)" <gi...@apache.org> on 2023/11/23 06:48:38 UTC
[PR] Fix Some Code Smells of Node Commons Module [iotdb]
cuibo01 opened a new pull request, #11604:
URL: https://github.com/apache/iotdb/pull/11604
Fix Some Code Smells of Node Commons Module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Some Code Smells of Node Commons Module [iotdb]
Posted by "wangchao316 (via GitHub)" <gi...@apache.org>.
wangchao316 merged PR #11604:
URL: https://github.com/apache/iotdb/pull/11604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Some Code Smells of Node Commons Module [iotdb]
Posted by "wangchao316 (via GitHub)" <gi...@apache.org>.
wangchao316 commented on code in PR #11604:
URL: https://github.com/apache/iotdb/pull/11604#discussion_r1402981304
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/authorizer/BasicAuthorizer.java:
##########
@@ -338,7 +338,7 @@ public Map<String, Boolean> getAllUserWaterMarkStatus() {
try {
userWaterMarkStatus.put(user, isUserUseWaterMark(user));
} catch (AuthException e) {
- LOGGER.error(String.format(NO_SUCH_USER_EXCEPTION, user));
+ LOGGER.error("No such user: {}", user, e);
Review Comment:
authexception does not print, have Security question
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org