[GitHub] [solr] HoustonPutman commented on a change in pull request #248: SOLR-6156: Fix NullPointerException if group.field grouping is used with rows=0 and timeAllowed

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #248:
URL: https://github.com/apache/solr/pull/248#discussion_r696828554



##########
File path: solr/core/src/java/org/apache/solr/search/grouping/CommandHandler.java
##########
@@ -216,6 +225,9 @@ private void searchWithTimeLimiter(Query query,
                                      ProcessedFilter filter, 
                                      Collector collector) throws IOException {
     if (queryCommand.getTimeAllowed() > 0 ) {
+      if (collector == null) {

Review comment:
       I see collector being used after this if statement. Should the null check go in the beginning of the method or are all the other usages fine with a null collector?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org