You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Joe Witt <jo...@gmail.com> on 2020/03/11 04:41:29 UTC

Re: Huge thanks to Travis-CI and Appveyor but.... Github Actions are much more stable

Team,

Once https://issues.apache.org/jira/browse/NIFI-7244 is merged we will also
be running the full suite of tests (except those not built to work on
windows) on Windows now as well.

So as PRs are submitted we're doing full builds with tests on Java 8 and
Java 11 across Linux, OSX, and Windows covering contrib check and locales
such as EN/FR/JP.

This is pretty strong coverage of the various ways users in the community
might use/develop NiFi.  There have been some tests which have emerged as
unstable in slower build environments.  We've been pretty aggressive in
spotting and killing these but work remains.

Thanks

On Tue, Feb 25, 2020 at 8:03 PM Joe Witt <jo...@gmail.com> wrote:

> Team,
>
> Just as another note on this topic...  NIFI-7201 is up and this PR means
> we have the following builds
>
>    - ubuntu Java 11 build on EN with full tests/contrib check
>    - ubuntu Java 8 build on FR with full tests/contrib check
>    - Java 8 OSX build on JP with full tests/contrib check
>    - Windows build without tests
>
>
> The key heads up there is we now have the EN/FR/JP builds up working again
> and we also do OSX now too.
>
>
> Thanks
>
> On Thu, Feb 20, 2020 at 7:49 PM Jeff Zhang <zj...@gmail.com> wrote:
>
>> Thanks Joe
>>
>> Joe Witt <jo...@gmail.com> 于2020年2月21日周五 上午11:16写道:
>>
>> > Jeff
>> >
>> > Take a look in the linked JIRA
>> > https://issues.apache.org/jira/browse/NIFI-7157 as there is a pretty
>> good
>> > set of links.
>> >
>> > This also reminds me - need to do this for NiFi Registry too
>> >
>> > Thanks
>> >
>> > On Thu, Feb 20, 2020 at 10:08 PM Jeff Zhang <zj...@gmail.com> wrote:
>> >
>> > > Thanks Joe for the create work. Do you mind to share how to setup
>> github
>> > > action for apache project ? Another project I am working on is also
>> > > interested to integrate with github action
>> > >
>> > > Joe Witt <jo...@gmail.com> 于2020年2月21日周五 上午8:48写道:
>> > >
>> > > > Team,
>> > > >
>> > > > Today we've merged a change into master which means the end of use
>> of
>> > > > Travis CI and Appveyor both of which have proven very unstable for
>> our
>> > > > builds.  And that isn't to suggest our builds are perfect but the
>> way
>> > > they
>> > > > work and the configuration options/expertise we have just isn't
>> lining
>> > > up.
>> > > >
>> > > > In https://issues.apache.org/jira/browse/NIFI-7157 we've merged a
>> > change
>> > > > which removes the travis-ci and appveyor build files and instead
>> adds
>> > > > .github/workflow directory with a single workflow right now which
>> is a
>> > ci
>> > > > build.
>> > > >
>> > > > It builds each time there is a push to any branch or a new pull
>> > request.
>> > > > It will do a Java 8 and 11 build on Ubuntu with full tests and
>> contrib
>> > > > checks.  It will also do a build on Windows without tests.  This
>> > > > effectively puts us on par with our previous setup except this
>> appears
>> > to
>> > > > be quite stable.
>> > > >
>> > > > This opens up other great options going forward too like supporting
>> the
>> > > > Github packages, other actions that might be helpful, and workflows
>> > like
>> > > > automated stale PR checks.  We can phase these in over time.
>> > > >
>> > > > There are probably some contributor guides and such to update and
>> we'll
>> > > > improve those as we go along.  You can also use these
>> actions/workflows
>> > > in
>> > > > your own forks on github so it is quite nice.
>> > > >
>> > > > You can start watching build progress now very nicely integrated
>> into
>> > > > github here at https://github.com/apache/nifi/actions
>> > > >
>> > > > Thanks
>> > > >
>> > >
>> > >
>> > > --
>> > > Best Regards
>> > >
>> > > Jeff Zhang
>> > >
>> >
>>
>>
>> --
>> Best Regards
>>
>> Jeff Zhang
>>
>

Re: Huge thanks to Travis-CI and Appveyor but.... Github Actions are much more stable

Posted by Joe Witt <jo...@gmail.com>.
Team,

Our lists of *very* old PRs or PRs not getting attention has grown quite
large.  As the Apache Spark community has done I plan to activate an
automated Stale PR Github CI action to close these.

https://github.com/apache/spark/blob/master/.github/workflows/stale.yml

I'm not sure how flexible it is but this will be a good start for us to get
better hygiene on these. For important items folks can reopen the PRs as
appropriate and this should help encourage discussions/docs/test plans
which make PR reviews easier as that is usually the biggest hurdle.

Thanks

On Wed, Mar 11, 2020 at 12:41 AM Joe Witt <jo...@gmail.com> wrote:

> Team,
>
> Once https://issues.apache.org/jira/browse/NIFI-7244 is merged we will
> also be running the full suite of tests (except those not built to work on
> windows) on Windows now as well.
>
> So as PRs are submitted we're doing full builds with tests on Java 8 and
> Java 11 across Linux, OSX, and Windows covering contrib check and locales
> such as EN/FR/JP.
>
> This is pretty strong coverage of the various ways users in the community
> might use/develop NiFi.  There have been some tests which have emerged as
> unstable in slower build environments.  We've been pretty aggressive in
> spotting and killing these but work remains.
>
> Thanks
>
> On Tue, Feb 25, 2020 at 8:03 PM Joe Witt <jo...@gmail.com> wrote:
>
>> Team,
>>
>> Just as another note on this topic...  NIFI-7201 is up and this PR means
>> we have the following builds
>>
>>    - ubuntu Java 11 build on EN with full tests/contrib check
>>    - ubuntu Java 8 build on FR with full tests/contrib check
>>    - Java 8 OSX build on JP with full tests/contrib check
>>    - Windows build without tests
>>
>>
>> The key heads up there is we now have the EN/FR/JP builds up working
>> again and we also do OSX now too.
>>
>>
>> Thanks
>>
>> On Thu, Feb 20, 2020 at 7:49 PM Jeff Zhang <zj...@gmail.com> wrote:
>>
>>> Thanks Joe
>>>
>>> Joe Witt <jo...@gmail.com> 于2020年2月21日周五 上午11:16写道:
>>>
>>> > Jeff
>>> >
>>> > Take a look in the linked JIRA
>>> > https://issues.apache.org/jira/browse/NIFI-7157 as there is a pretty
>>> good
>>> > set of links.
>>> >
>>> > This also reminds me - need to do this for NiFi Registry too
>>> >
>>> > Thanks
>>> >
>>> > On Thu, Feb 20, 2020 at 10:08 PM Jeff Zhang <zj...@gmail.com> wrote:
>>> >
>>> > > Thanks Joe for the create work. Do you mind to share how to setup
>>> github
>>> > > action for apache project ? Another project I am working on is also
>>> > > interested to integrate with github action
>>> > >
>>> > > Joe Witt <jo...@gmail.com> 于2020年2月21日周五 上午8:48写道:
>>> > >
>>> > > > Team,
>>> > > >
>>> > > > Today we've merged a change into master which means the end of use
>>> of
>>> > > > Travis CI and Appveyor both of which have proven very unstable for
>>> our
>>> > > > builds.  And that isn't to suggest our builds are perfect but the
>>> way
>>> > > they
>>> > > > work and the configuration options/expertise we have just isn't
>>> lining
>>> > > up.
>>> > > >
>>> > > > In https://issues.apache.org/jira/browse/NIFI-7157 we've merged a
>>> > change
>>> > > > which removes the travis-ci and appveyor build files and instead
>>> adds
>>> > > > .github/workflow directory with a single workflow right now which
>>> is a
>>> > ci
>>> > > > build.
>>> > > >
>>> > > > It builds each time there is a push to any branch or a new pull
>>> > request.
>>> > > > It will do a Java 8 and 11 build on Ubuntu with full tests and
>>> contrib
>>> > > > checks.  It will also do a build on Windows without tests.  This
>>> > > > effectively puts us on par with our previous setup except this
>>> appears
>>> > to
>>> > > > be quite stable.
>>> > > >
>>> > > > This opens up other great options going forward too like
>>> supporting the
>>> > > > Github packages, other actions that might be helpful, and workflows
>>> > like
>>> > > > automated stale PR checks.  We can phase these in over time.
>>> > > >
>>> > > > There are probably some contributor guides and such to update and
>>> we'll
>>> > > > improve those as we go along.  You can also use these
>>> actions/workflows
>>> > > in
>>> > > > your own forks on github so it is quite nice.
>>> > > >
>>> > > > You can start watching build progress now very nicely integrated
>>> into
>>> > > > github here at https://github.com/apache/nifi/actions
>>> > > >
>>> > > > Thanks
>>> > > >
>>> > >
>>> > >
>>> > > --
>>> > > Best Regards
>>> > >
>>> > > Jeff Zhang
>>> > >
>>> >
>>>
>>>
>>> --
>>> Best Regards
>>>
>>> Jeff Zhang
>>>
>>