You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "csun5285 (via GitHub)" <gi...@apache.org> on 2026/10/08 10:48:40 UTC

[PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222) [doris]

csun5285 opened a new pull request, #68788:
URL: https://github.com/apache/doris/pull/68788

   pick #61713 and #62222 (partial: keeps enable_common_expr_pushdown, no shared scan LIMIT counter, no key-expression pushdown for tables merged on read; details in the commit message)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6076604341

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e63cc1ea9406add9326fb550181fdd9999761db3_e63cc1ea9406add9326fb550181fdd9999761db3_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e63cc1ea9406add9326fb550181fdd9999761db3_e63cc1ea9406add9326fb550181fdd9999761db3_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 78.49% (1960/2497) |
   | Line Coverage     | 65.43% (35311/53964) |
   | Region Coverage   | 53.08% (33991/64043) |
   | Branch Coverage   | 55.88% (10485/18762) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6127668572

   # FE Regression Coverage Report
   Increment line coverage `  36.84% (7/19)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/68788_0d098c16bd44c759b7c58b2f609eec3405ce2b38_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/68788_0d098c16bd44c759b7c58b2f609eec3405ce2b38_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222) [doris]

Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6121632251

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on code in PR #68788:
URL: https://github.com/apache/doris/pull/68788#discussion_r4256009309


##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -3159,18 +3200,28 @@ Status SegmentIterator::_next_batch_internal(Block* block) {
     if (_count_emit_shortcut) {
         return _emit_count_shortcut_batch(block);
     }
+    if (_opts.read_limit > 0 && _rows_returned >= _opts.read_limit) {

Review Comment:
   master 存在这个问题,先在master修复,然后pick 到 4.2



##########
be/src/exec/operator/olap_scan_operator.cpp:
##########
@@ -436,12 +436,66 @@ Status OlapScanLocalState::_init_profile() {
     return Status::OK();
 }
 
+static bool contains_expr_node_type(const VExprSPtr& expr, TExprNodeType::type node_type) {
+    DORIS_CHECK(expr != nullptr);
+    if (expr->node_type() == node_type) {
+        return true;
+    }
+    if (expr->is_rf_wrapper() && contains_expr_node_type(expr->get_impl(), node_type)) {
+        return true;
+    }
+    return std::ranges::any_of(expr->children(), [node_type](const auto& child) {
+        return contains_expr_node_type(child, node_type);
+    });
+}
+
+static Status validate_residual_scan_conjuncts(RuntimeState* state,
+                                               TPushAggOp::type push_down_agg_type,
+                                               const VExprContextSPtrs& conjuncts) {
+    for (const auto& conjunct : conjuncts) {
+        const auto& root = conjunct->root();
+        if (contains_expr_node_type(root, TExprNodeType::SEARCH_EXPR)) {
+            return Status::InvalidArgument(
+                    "SEARCH expression remains as a residual scan predicate. A valid search() "
+                    "must bind at least one indexed field and be evaluated in SegmentIterator, "
+                    "which takes such expressions only when the table is not merged on read "
+                    "(DUPLICATE, or UNIQUE with merge-on-write). enable_segment_limit_pushdown "
+                    "only controls SegmentIterator LIMIT pushdown and cannot make residual "
+                    "SEARCH executable.");
+        }
+        if (!state->query_options().enable_match_without_inverted_index &&
+            contains_expr_node_type(root, TExprNodeType::MATCH_PRED)) {
+            return Status::InvalidArgument(
+                    "MATCH expression remains as a residual scan predicate and would fall back to "
+                    "a disabled slow path because enable_match_without_inverted_index is false. "
+                    "SegmentIterator evaluates MATCH only when the table is not merged on read "
+                    "(DUPLICATE, or UNIQUE with merge-on-write). enable_segment_limit_pushdown "
+                    "only controls SegmentIterator LIMIT pushdown and cannot make residual MATCH "
+                    "executable. Set enable_match_without_inverted_index=true to allow slow MATCH "
+                    "execution.");
+        }
+    }
+
+    if (push_down_agg_type == TPushAggOp::COUNT_ON_INDEX && !conjuncts.empty()) {

Review Comment:
   master 存在这个问题,先在master修复,然后pick 到 4.2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6059359151

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/ddf758977d61aa4a24704b34aa98b4433b3509ad_ddf758977d61aa4a24704b34aa98b4433b3509ad_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/ddf758977d61aa4a24704b34aa98b4433b3509ad_ddf758977d61aa4a24704b34aa98b4433b3509ad_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 78.49% (1960/2497) |
   | Line Coverage     | 65.46% (35323/53964) |
   | Region Coverage   | 53.07% (33989/64043) |
   | Branch Coverage   | 55.86% (10480/18762) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6139429235

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6058203219

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6061438912

   # FE UT Coverage Report
   Increment line coverage `  100.00% (2/2)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/68788_ddf758977d61aa4a24704b34aa98b4433b3509ad/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/68788_ddf758977d61aa4a24704b34aa98b4433b3509ad/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6139430415

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222) [doris]

Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6058207869

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6144195121

   # FE Regression Coverage Report
   Increment line coverage `  1.79% (4/224)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/68788_7cce8383538bac3cbc970c7ad307d03b2b90d061_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/68788_7cce8383538bac3cbc970c7ad307d03b2b90d061_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #68788:
URL: https://github.com/apache/doris/pull/68788#discussion_r4255497184


##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -3159,18 +3200,28 @@ Status SegmentIterator::_next_batch_internal(Block* block) {
     if (_count_emit_shortcut) {
         return _emit_count_shortcut_batch(block);
     }
+    if (_opts.read_limit > 0 && _rows_returned >= _opts.read_limit) {

Review Comment:
   [P1] Keep LIMIT exhaustion from publishing a partial condition cache
   
   This new EOF also reaches `next_batch()`'s unconditional condition-cache insertion at lines 3098-3107, although the segment has not been fully evaluated. With `enable_condition_cache=true`, `topn_filter_ratio=0`, and a DUP table containing an overlapping multi-segment rowset, `WHERE abs(v) > 0 ORDER BY k LIMIT 1` enables storage TopN. `VMergeIterator::_next_batch()` advances each consumed child block and requests another batch before the scanner can stop, so this branch publishes the cache. Only rows retained by LIMIT were marked after `_apply_read_limit_to_selected_rows()`; other 2048-row granules remain false. A later query with the same predicate and a larger/no LIMIT reuses the predicate digest and discards those granules, silently omitting matching rows. Skip cache publication when EOF is caused by the read budget, or conservatively mark unvisited/discarded granules as possibly matching.



##########
be/src/exec/operator/olap_scan_operator.cpp:
##########
@@ -436,12 +436,66 @@ Status OlapScanLocalState::_init_profile() {
     return Status::OK();
 }
 
+static bool contains_expr_node_type(const VExprSPtr& expr, TExprNodeType::type node_type) {
+    DORIS_CHECK(expr != nullptr);
+    if (expr->node_type() == node_type) {
+        return true;
+    }
+    if (expr->is_rf_wrapper() && contains_expr_node_type(expr->get_impl(), node_type)) {
+        return true;
+    }
+    return std::ranges::any_of(expr->children(), [node_type](const auto& child) {
+        return contains_expr_node_type(child, node_type);
+    });
+}
+
+static Status validate_residual_scan_conjuncts(RuntimeState* state,
+                                               TPushAggOp::type push_down_agg_type,
+                                               const VExprContextSPtrs& conjuncts) {
+    for (const auto& conjunct : conjuncts) {
+        const auto& root = conjunct->root();
+        if (contains_expr_node_type(root, TExprNodeType::SEARCH_EXPR)) {
+            return Status::InvalidArgument(
+                    "SEARCH expression remains as a residual scan predicate. A valid search() "
+                    "must bind at least one indexed field and be evaluated in SegmentIterator, "
+                    "which takes such expressions only when the table is not merged on read "
+                    "(DUPLICATE, or UNIQUE with merge-on-write). enable_segment_limit_pushdown "
+                    "only controls SegmentIterator LIMIT pushdown and cannot make residual "
+                    "SEARCH executable.");
+        }
+        if (!state->query_options().enable_match_without_inverted_index &&
+            contains_expr_node_type(root, TExprNodeType::MATCH_PRED)) {
+            return Status::InvalidArgument(
+                    "MATCH expression remains as a residual scan predicate and would fall back to "
+                    "a disabled slow path because enable_match_without_inverted_index is false. "
+                    "SegmentIterator evaluates MATCH only when the table is not merged on read "
+                    "(DUPLICATE, or UNIQUE with merge-on-write). enable_segment_limit_pushdown "
+                    "only controls SegmentIterator LIMIT pushdown and cannot make residual MATCH "
+                    "executable. Set enable_match_without_inverted_index=true to allow slow MATCH "
+                    "execution.");
+        }
+    }
+
+    if (push_down_agg_type == TPushAggOp::COUNT_ON_INDEX && !conjuncts.empty()) {

Review Comment:
   [P2] Fall back for COUNT queries with slotless volatile predicates
   
   On a DUP/MOW table with an inverted index, `SELECT count(*) FROM t WHERE random() < 2` reaches this guard with the default `enable_count_on_index_pushdown=true`:
   
   ```text
   Aggregate(count(*))
     Filter(random() < 2)
       Scan(indexed_table)
   ```
   
   `AggregateStrategies.COUNT_ON_INDEX_WITHOUT_PROJECT` accepts this because COUNT(*) has no input slots, and `visitPhysicalFilter()` puts the predicate on the COUNT_ON_INDEX scan. A single `random()` is neither folded nor extracted into a separate Project. In BE it is nonconstant and has no slot, so normalization retains it in `_conjuncts` instead of pushing it into SegmentIterator. The previous COUNT_ON_INDEX path emitted one row per source record and the scanner safely evaluated this predicate before the upper COUNT; since random() returns values in [0,1), this example returns the full row count. The new unconditional rejection turns that valid query into InvalidArgument. Preserve safe row-shaped residual evaluation or fall back to ordinary scanning/counting before enabling this pushdown.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222) [doris]

Posted by "csun5285 (via GitHub)" <gi...@apache.org>.
csun5285 commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6076236452

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6124375583

   # FE UT Coverage Report
   Increment line coverage `  21.05% (4/19)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/68788_0d098c16bd44c759b7c58b2f609eec3405ce2b38/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/68788_0d098c16bd44c759b7c58b2f609eec3405ce2b38/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #68788:
URL: https://github.com/apache/doris/pull/68788


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6078613305

   # FE UT Coverage Report
   Increment line coverage `  100.00% (2/2)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/68788_e63cc1ea9406add9326fb550181fdd9999761db3/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/68788_e63cc1ea9406add9326fb550181fdd9999761db3/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6138801983

   # FE Regression Coverage Report
   Increment line coverage `  0.99% (7/710)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/68788_0d098c16bd44c759b7c58b2f609eec3405ce2b38_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/68788_0d098c16bd44c759b7c58b2f609eec3405ce2b38_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6141990495

   # FE UT Coverage Report
   Increment line coverage `  21.05% (4/19)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/68788_7cce8383538bac3cbc970c7ad307d03b2b90d061/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/68788_7cce8383538bac3cbc970c7ad307d03b2b90d061/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.2: [Improvement](scan) Push down LIMIT to segment iterator (#61713 #62222 #64285 #64479 #68804) [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #68788:
URL: https://github.com/apache/doris/pull/68788#issuecomment-6139363290

   /review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org