You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "EnxDev (via GitHub)" <gi...@apache.org> on 2026/01/02 11:13:37 UTC
[PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
EnxDev opened a new pull request, #36889:
URL: https://github.com/apache/superset/pull/36889
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR fixes a cosmetic issue in the dashboard tab reordering feature where the cursor would incorrectly show as a drag cursor when hovering over the tab title input field.
**The Problem**
When hovering over the input field used to edit tab names, the drag cursor would appear instead of the text cursor, even though editing was still possible. This created a confusing user experience where the visual feedback didn't match the expected behavior.
**The Solution**
We customize the `PointerSensor.activators` to check if the pointer target is an interactive element (input, textarea, or contentEditable).
When an interactive element is detected, drag activation is prevented, allowing the browser to show the correct text cursor and making the interaction feel more natural.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
- Before
https://github.com/user-attachments/assets/ffb50273-e3c4-4a58-bd81-f1e9b767c05e
- After
https://github.com/user-attachments/assets/a3b8a66c-d16d-4f32-9f72-56171d5c8873
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
es new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3810451191
## **Sequence Diagram**
The PR customizes PointerSensor activation to detect interactive elements (input/textarea/contentEditable) and prevent drag activation when the user clicks them, so editing tab titles shows the text cursor instead of starting a drag.
```mermaid
sequenceDiagram
participant User
participant TabsUI as Tabs Renderer
participant PointerSensor
participant DnD as DndContext
participant Browser
User->>TabsUI: Pointer down on tab title
TabsUI->>PointerSensor: Check activation target
PointerSensor->>PointerSensor: Is target input/textarea/contentEditable?
alt Target is interactive
PointerSensor-->>TabsUI: Prevent drag activation
TabsUI-->>Browser: Let browser show text cursor / allow editing
Browser-->>User: Text cursor, edit title
else Target not interactive
PointerSensor-->>Dnd: Activate drag
Dnd-->>TabsUI: Reorder tabs (update state)
TabsUI-->>User: Tab reordered
end
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-5037982733
@EnxDev any interest in reworking this along the lines @geido suggested back in January, i.e. only suppress the drag indicator once dragging's actually started, rather than disabling drag entirely over the title? It's a nice fix otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r3635459794
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.test.tsx:
##########
@@ -199,4 +201,24 @@ describe('TabsRenderer', () => {
expect(screen.getByText('Tab 1 Content')).toBeInTheDocument();
expect(screen.queryByText('Tab 2 Content')).not.toBeInTheDocument(); // Not active
});
+
+ test('activates dragging when the pointer starts on a tab title input', () => {
+ // Tab titles render a textarea that covers most of the tab in edit mode
+ const textarea = document.createElement('textarea');
+ document.body.appendChild(textarea);
+ const nativeEvent = new MouseEvent('pointerdown', { button: 0 });
+ Object.defineProperty(nativeEvent, 'isPrimary', { value: true });
+ textarea.dispatchEvent(nativeEvent);
+
+ const [activator] = PointerSensor.activators;
+ const onActivation = jest.fn();
+ const activated = activator.handler(
+ { nativeEvent } as unknown as PointerEvent<HTMLElement>,
+ { onActivation },
+ );
+
+ expect(nativeEvent.target).toBe(textarea);
+ expect(activated).toBe(true);
+ expect(onActivation).toHaveBeenCalled();
+ });
Review Comment:
**Suggestion:** This test validates the opposite of the stated fix: it expects drag activation when the pointer starts on the tab title input. If the intended behavior is to disable drag initiation from editable inputs, this assertion will lock in incorrect behavior and allow regressions in the real fix. Update the expectation to assert that activation is blocked for input/textarea targets. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Unit test enforces dragging from tab title inputs.
- ⚠️ Behavior contradicts PR requirement to disable drag.
- ⚠️ Future drag-disabling changes will fail this misaligned test.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Run the frontend Jest test suite so that
`superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.test.tsx`
is executed, and locate the test named `activates dragging when the pointer starts on a
tab title input` at lines 205–223.
2. Observe that this test manually creates a `textarea` element, appends it to
`document.body` (lines 207–208), synthesizes a `MouseEvent('pointerdown', { button: 0 })`,
and sets `nativeEvent.isPrimary = true` (lines 209–210) before dispatching it on the
textarea (line 211).
3. The test then retrieves the first pointer activator from `PointerSensor.activators`
(line 213) and calls `activator.handler({ nativeEvent } as unknown as
PointerEvent<HTMLElement>, { onActivation })` (lines 215–217), asserting that the handler
returns `true` and that `onActivation` is called (lines 220–222), thereby explicitly
encoding that drag activation should succeed when the pointer originates on a textarea tab
title input.
4. Compare this encoded behavior with the PR title and description, which state that
drag/tab reordering should be disabled when interacting with tab title input fields; the
mismatch demonstrates that the automated test suite currently enforces behavior opposite
to the specified requirement, so any implementation that correctly disables drag from
inputs will fail this test and be blocked until the expectation is updated.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a54f1fa2d2614f73bed6b66726caa940&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a54f1fa2d2614f73bed6b66726caa940&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.test.tsx
**Line:** 205:223
**Comment:**
*Logic Error: This test validates the opposite of the stated fix: it expects drag activation when the pointer starts on the tab title input. If the intended behavior is to disable drag initiation from editable inputs, this assertion will lock in incorrect behavior and allow regressions in the real fix. Update the expectation to assert that activation is blocked for input/textarea targets.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F36889&comment_hash=4a190b3f9f4bbc9ded019468423480231bbb7339ef2c16c11914241b0063b04b&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F36889&comment_hash=4a190b3f9f4bbc9ded019468423480231bbb7339ef2c16c11914241b0063b04b&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r3635470244
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.test.tsx:
##########
@@ -199,4 +201,24 @@ describe('TabsRenderer', () => {
expect(screen.getByText('Tab 1 Content')).toBeInTheDocument();
expect(screen.queryByText('Tab 2 Content')).not.toBeInTheDocument(); // Not active
});
+
+ test('activates dragging when the pointer starts on a tab title input', () => {
+ // Tab titles render a textarea that covers most of the tab in edit mode
+ const textarea = document.createElement('textarea');
+ document.body.appendChild(textarea);
+ const nativeEvent = new MouseEvent('pointerdown', { button: 0 });
+ Object.defineProperty(nativeEvent, 'isPrimary', { value: true });
+ textarea.dispatchEvent(nativeEvent);
+
+ const [activator] = PointerSensor.activators;
+ const onActivation = jest.fn();
+ const activated = activator.handler(
+ { nativeEvent } as unknown as PointerEvent<HTMLElement>,
+ { onActivation },
+ );
+
+ expect(nativeEvent.target).toBe(textarea);
+ expect(activated).toBe(true);
+ expect(onActivation).toHaveBeenCalled();
+ });
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag tests that assert drag activation is allowed from the tab title in TabsRenderer; this is an intentional regression guard for the cursor-only behavior, not a bug.
**Applied to:**
- `superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3846108650
## **Sequence Diagram**
The PR customizes PointerSensor activation so pointer-down on input/textarea/contentEditable elements does not start a drag; this preserves the text cursor and allows editing, while non-interactive areas still activate drag-and-drop reordering.
```mermaid
sequenceDiagram
participant User
participant PointerSensor
participant Browser
participant DndContext
participant TabsRenderer
User->>PointerSensor: pointerDown on tab title
PointerSensor->>PointerSensor: check target is input/textarea/contentEditable?
alt target is interactive
PointerSensor-->>Browser: do not activate drag (return false)
Browser-->>User: show text cursor, allow editing
else target is non-interactive
PointerSensor->>DndContext: onActivation -> start drag
DndContext->>TabsRenderer: onDragStart (set active tab)
User->>DndContext: drag & drop
DndContext->>TabsRenderer: onDragEnd -> onTabsReorder(oldIndex, newIndex)
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705117219
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/20656727628) for [ad53a4c](https://github.com/apache/superset/commit/ad53a4c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-5054293214
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/29979257269) for [dbe994d](https://github.com/apache/superset/commit/dbe994d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705111706
CodeAnt AI is reviewing your PR.
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r3635465593
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx:
##########
@@ -72,10 +72,16 @@ const StyledTabsContainer = styled.div<{ isDragging?: boolean }>`
}
}
- /* Hide ink-bar during drag */
${({ isDragging }) =>
isDragging &&
`
+ /* Show the drag indicator during drag, over the tab title textarea too */
+ &&,
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to replace `&&` with `&` is incorrect in this context. As you noted, `&&` is a valid and deliberate use of emotion's parent-selector interpolation, which increases the CSS specificity to (0,3,0). This is necessary to override the existing `EditableTitle` styles and ensure the `cursor: move` property is correctly applied during drag operations. You should disregard the suggestion to change it to `&`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-5054272934
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/29978135727) for [95645d3](https://github.com/apache/superset/commit/95645d3)
• **Environment:** http://44.255.38.221:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r2657541770
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx:
##########
@@ -37,6 +37,36 @@ import {
useSensor,
closestCenter,
} from '@dnd-kit/core';
+
+const isInteractiveElement = (element: HTMLElement | null): boolean => {
+ if (!element) return false;
+ const tagName = element.tagName.toUpperCase();
+ if (
+ tagName === 'INPUT' ||
+ tagName === 'TEXTAREA' ||
+ element.isContentEditable
+ ) {
+ return true;
+ }
+ return isInteractiveElement(element.parentElement);
+};
+
+PointerSensor.activators = [
+ {
+ eventName: 'onPointerDown' as const,
+ handler: ({ nativeEvent: event }, { onActivation }) => {
+ if (
+ event.button !== 0 ||
+ isInteractiveElement(event.target as HTMLElement)
+ ) {
+ return false;
+ }
+ onActivation?.({ event });
Review Comment:
**Suggestion:** The custom `PointerSensor.activators` handler calls `onActivation` directly on pointer down whenever the conditions pass, which bypasses the configured `activationConstraint: { distance: 10 }` on the sensor; this means drags will start immediately instead of after the intended movement threshold, causing unintended drags when users just click tabs. [logic error]
**Severity Level:** Minor ⚠️
```suggestion
handler: ({ nativeEvent: event }) => {
if (
event.button !== 0 ||
isInteractiveElement(event.target as HTMLElement)
) {
return false;
}
// Returning true lets the default PointerSensor logic
// (including activationConstraint) decide when to activate
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
The current activator explicitly calls onActivation on pointer down which forces immediate activation and indeed bypasses the PointerSensor's activationConstraint (distance: 10) supplied when creating the sensor. In dnd-kit the handler should return true to indicate the event is a potential activation and let the sensor's own logic (including distance threshold) decide when to call onActivation. The suggested change fixes a real logic bug that causes accidental drags when clicking tabs.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx
**Line:** 57:64
**Comment:**
*Logic Error: The custom `PointerSensor.activators` handler calls `onActivation` directly on pointer down whenever the conditions pass, which bypasses the configured `activationConstraint: { distance: 10 }` on the sensor; this means drags will start immediately instead of after the intended movement threshold, causing unintended drags when users just click tabs.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3711218862
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/20722268461) for [b5e76cc](https://github.com/apache/superset/commit/b5e76cc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev merged PR #36889:
URL: https://github.com/apache/superset/pull/36889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3745017011
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | f80c46005e6c0367d32185718896bc4b9723d1e8 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/696664dcacd79400088bbe7f |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-36889--superset-docs-preview.netlify.app](https://deploy-preview-36889--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-36889--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3771700291
CodeAnt AI is running Incremental review
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705114721
## Nitpicks 🔍
<table>
<tr><td>🔒 <strong>No security issues identified</strong></td></tr>
<tr><td>⚡ <strong>Recommended areas for review</strong><br><br>
- [ ] <a href='https://github.com/apache/superset/pull/36889/files#diff-aeab17efd0df9e6433e1b0a7ca86dab44c3496e8a55b62b7d0a4af57b9254e12R54-R68'><strong>Global Mutation</strong></a><br>The PR mutates `PointerSensor.activators` at module initialization. This changes dnd-kit global behavior for all consumers and may have unintended side effects across the app or other DnD contexts. Prefer passing custom activators to the specific sensor instance (via useSensor) instead of mutating the library export.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36889/files#diff-aeab17efd0df9e6433e1b0a7ca86dab44c3496e8a55b62b7d0a4af57b9254e12R54-R68'><strong>Import-time Side Effects</strong></a><br>The active code runs at module import time. If this file is imported in SSR or other contexts unexpectedly, it produces side effects by overriding the sensor behavior globally. Consider scoping the override to client-side init or the component lifecycle.<br>
- [ ] <a href='https://github.com/apache/superset/pull/36889/files#diff-aeab17efd0df9e6433e1b0a7ca86dab44c3496e8a55b62b7d0a4af57b9254e12R41-R52'><strong>DOM Traversal Safety</strong></a><br>`isInteractiveElement` uses recursion and assumes the node is an HTMLElement with a `tagName`. `event.target` may be a text node or non-HTMLElement (SVG, etc.). The recursive implementation could cause a stack overflow on very deep trees and may throw when encountering non-element nodes. Use an iterative traversal, guard node types, and stop at document/body.<br>
</td></tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-5055387596
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705184413
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/20657404892) for [b5e76cc](https://github.com/apache/superset/commit/b5e76cc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3711289684
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/20722268461) for [b5e76cc](https://github.com/apache/superset/commit/b5e76cc)
• **Environment:** http://35.95.20.49:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-4325600049
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/36889?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `35.29412%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 64.47%. Comparing base ([`a216b23`](https://app.codecov.io/gh/apache/superset/commit/a216b23d5a3fe9753419b668e851c08150bfeaa7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a3c5d03`](https://app.codecov.io/gh/apache/superset/commit/a3c5d0356d858486711f49ab6ff6336eaa7ea68a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 9 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/36889?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...nents/gridComponents/TabsRenderer/TabsRenderer.tsx](https://app.codecov.io/gh/apache/superset/pull/36889?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fdashboard%2Fcomponents%2FgridComponents%2FTabsRenderer%2FTabsRenderer.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1RhYnNSZW5kZXJlci9UYWJzUmVuZGVyZXIudHN4) | 35.29% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/36889?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #36889 +/- ##
==========================================
- Coverage 64.48% 64.47% -0.01%
==========================================
Files 2566 2566
Lines 133926 133943 +17
Branches 31096 31104 +8
==========================================
+ Hits 86357 86363 +6
- Misses 46074 46085 +11
Partials 1495 1495
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/36889/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/36889/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.54% <35.29%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/36889?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r3635465102
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx:
##########
@@ -72,10 +72,16 @@ const StyledTabsContainer = styled.div<{ isDragging?: boolean }>`
}
}
- /* Hide ink-bar during drag */
${({ isDragging }) =>
isDragging &&
`
+ /* Show the drag indicator during drag, over the tab title textarea too */
+ &&,
Review Comment:
&& isn't raw CSS it's emotion's parent-selector interpolation, and it compiles to a doubled class: `.css-x.css-x .editable-title * { cursor: move }`. Valid CSS, and it is emitted, not ignored.
The doubling is deliberate. It competes with EditableTitle's own `.css-z.editable-title textarea { cursor: initial }` at `specificity (0,2,1)`. With `&&` we're at (0,3,0) and win; with a single & we'd be at (0,2,0) and lose; the cursor stays auto, which is the bug this PR fixes. Verified in Chromium: && → move, & → auto.
The & rule even comes later in source order and still loses, so it's specificity, not ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705986252
> Better ask for product feedback if you want to go with option 2
Yes, I believe the changes I introduced in this PR could be integrated with option 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705139583
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/20656727628) for [ad53a4c](https://github.com/apache/superset/commit/ad53a4c)
• **Environment:** http://54.218.223.66:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3771715470
CodeAnt AI Incremental review completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-5054151666
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/29978135727) for [95645d3](https://github.com/apache/superset/commit/95645d3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-5054431471
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/29979257269) for [dbe994d](https://github.com/apache/superset/commit/dbe994d)
• **Environment:** http://52.38.108.45:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3771704498
## **Sequence Diagram**
Shows how the PR customizes the PointerSensor activators to prevent drag activation when the user interacts with editable tab title fields, preserving normal text editing instead of starting a tab reorder.
```mermaid
sequenceDiagram
participant User
participant Browser
participant PointerSensor
participant DndContext
participant TabsRenderer
User->>Browser: pointerdown on tab title (target)
Browser->>PointerSensor: onPointerDown event (nativeEvent)
PointerSensor->>PointerSensor: isInteractiveElement(target)?
alt target is input/textarea/contentEditable
PointerSensor-->>Browser: return false (no activation)
Browser-->>User: show text cursor / allow editing
else non-interactive target
PointerSensor->>DndContext: onActivation -> start drag
DndContext-->>TabsRenderer: onDragStart -> setActiveId
DndContext->>DndContext: drag and drop occurs
DndContext-->>TabsRenderer: onDragEnd -> call onTabsReorder (if moved)
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705984017
> The original issue was that when dragging an active tab it would not show the drag indicator. We have a few possible paths here:
> - Show the drag indicator only when dragging has actually started.
> - Add an additional dragging area (before or after the tab title) that would indicate to the user that dragging can be done by targeting that specific area - very common pattern.
> - Accept that an active tab is also editable and never show the drag indicator (previous behavior) - acceptable but not perfect.
>
> I think option 1 is viable and option 2 is ideal.
>
> The change introduced in this PR seems to have an issue for which dragging would not be possible at all if you are hovering the tab text - which is definitely something we don't want.
The changes introduced prevent the tab from being dragged when it is selected and the cursor is over the input field.
This ensures that the indicator remains visible, making it clear to the user that the text can be edited.
Personally, I feel that with the proposed options it may not always be very clear when the tab can be edited versus when it can be moved.
To make this behavior clearer, we could consider adding a pencil icon to indicate that the text is editable.
This would help clarify the interaction and still allow the user to drag the element by selecting it from the remaining available space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705118247
CodeAnt AI finished reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-5052818431
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r3634739803
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.tsx:
##########
@@ -72,10 +72,16 @@ const StyledTabsContainer = styled.div<{ isDragging?: boolean }>`
}
}
- /* Hide ink-bar during drag */
${({ isDragging }) =>
isDragging &&
`
+ /* Show the drag indicator during drag, over the tab title textarea too */
+ &&,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Invalid CSS selector syntax</b></div>
<div id="fix">
The `&&` selector on line 79 is invalid CSS syntax. In styled-components template literals, the parent selector is `&` (with a leading colon), not `&&`. This will cause the cursor: move rule to be silently ignored for the StyledTabsContainer during drag. The fix is to replace `&&` with `&`.
</div>
</div>
<small><i>Code Review Run #420918</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #36889:
URL: https://github.com/apache/superset/pull/36889#discussion_r3635468760
##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.test.tsx:
##########
@@ -199,4 +201,24 @@ describe('TabsRenderer', () => {
expect(screen.getByText('Tab 1 Content')).toBeInTheDocument();
expect(screen.queryByText('Tab 2 Content')).not.toBeInTheDocument(); // Not active
});
+
+ test('activates dragging when the pointer starts on a tab title input', () => {
+ // Tab titles render a textarea that covers most of the tab in edit mode
+ const textarea = document.createElement('textarea');
+ document.body.appendChild(textarea);
+ const nativeEvent = new MouseEvent('pointerdown', { button: 0 });
+ Object.defineProperty(nativeEvent, 'isPrimary', { value: true });
+ textarea.dispatchEvent(nativeEvent);
+
+ const [activator] = PointerSensor.activators;
+ const onActivation = jest.fn();
+ const activated = activator.handler(
+ { nativeEvent } as unknown as PointerEvent<HTMLElement>,
+ { onActivation },
+ );
+
+ expect(nativeEvent.target).toBe(textarea);
+ expect(activated).toBe(true);
+ expect(onActivation).toHaveBeenCalled();
+ });
Review Comment:
The premise is inverted. Disabling drag from the title was the original approach here, and it was rejected in review; it made tabs undraggable whenever the pointer was over the tab text.
The intended behavior is the opposite: drag stays available from the title, and only the cursor changes, once dragging has actually started.
So this test asserts the fix, not against it; it's the regression guard that stops the sensor override from coming back. Note activation ≠ drag start: the sensor's 10px distance constraint still gates that, so a plain click on the title enters edit mode and accepts typing as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3744980686
CodeAnt AI is running Incremental review
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705113445
## **Sequence Diagram**
Shows how pointer events are routed to the PointerSensor which now detects interactive elements (input/textarea/contentEditable). If interactive, drag activation is prevented so the user can edit the tab title; otherwise the normal drag-reorder flow proceeds.
```mermaid
sequenceDiagram
participant User
participant Browser
participant PointerSensor
participant DndContext
participant TabsRenderer
User->>Browser: Pointer down on tab title
Browser->>PointerSensor: Deliver pointer event
alt Target is interactive (input/textarea/contentEditable)
PointerSensor-->>Browser: Prevent drag activation
Browser-->>User: Show text cursor / allow editing
User->>TabsRenderer: Edit tab title
TabsRenderer-->>User: Save/display updated title
else Target is non-interactive
PointerSensor->>DndContext: Activate drag
DndContext->>TabsRenderer: Reorder tabs onDragEnd
TabsRenderer-->>User: Render reordered tabs
end
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705111811
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705285255
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705212656
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/20657404892) for [b5e76cc](https://github.com/apache/superset/commit/b5e76cc)
• **Environment:** http://35.94.203.45:8080 (admin/admin)
• **Lifetime:** 48h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard-tabs): disable drag on input fields during tab reorder [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on PR #36889:
URL: https://github.com/apache/superset/pull/36889#issuecomment-3705981999
> The original issue was that when dragging an active tab it would not show the drag indicator. We have a few possible paths here:
>
> * Show the drag indicator only when dragging has actually started.
> * Add an additional dragging area (before or after the tab title) that would indicate to the user that dragging can be done by targeting that specific area - very common pattern.
> * Accept that an active tab is also editable and never show the drag indicator (previous behavior) - acceptable but not perfect.
>
> I think option 1 is viable and option 2 is ideal.
>
> The change introduced in this PR seems to have an issue for which dragging would not be possible at all if you are hovering the tab text - which is definitely something we don't want.
Better ask for product feedback if you want to go with option 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org