You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/26 14:36:47 UTC
[GitHub] [camel-website] zregvart commented on a change in pull request
#270: New section added in frontpage
zregvart commented on a change in pull request #270: New section added in frontpage
URL: https://github.com/apache/camel-website/pull/270#discussion_r398618447
##########
File path: antora-ui-camel/src/css/frontpage.css
##########
@@ -237,6 +237,10 @@ section.frontpage h1 {
flex: 100%;
}
+ .box-new {
Review comment:
Can't we use the existing `box` class? Naming things `-new` leads to naming the next new thing `-newer` and the thing after that one `-newest` and so on. This is never a good practice. Read [this](https://www.w3.org/QA/Tips/goodclassnames).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services