You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "lxy-9602 (via GitHub)" <gi...@apache.org> on 2026/09/14 10:09:59 UTC
[PR] refactor(global-index): extract common sorted index components [paimon-cpp]
lxy-9602 opened a new pull request, #343:
URL: https://github.com/apache/paimon-cpp/pull/343
<!-- PR titles must follow Conventional Commits: <type>(<optional-scope>): <description> -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: #316
<!-- What is the purpose of the change -->
This change extracts BTree-specific sorted index utilities into reusable global index components, preparing them for the bitmap global index implementation.
The main changes are:
- Move `KeySerializer` from the BTree directory to the common global index directory.
- Change `KeySerializer` from a static utility into a reusable instance associated with a key type and memory pool.
- Rename `BTreeIndexMeta` to `SortedIndexFileMeta`, matching the corresponding Java class.
- Rename `BTreeFileMetaSelector` to `SortedFileMetaSelector`, matching the corresponding Java class.
- Update BTree writers and readers to reuse the common serializer, metadata, and file selector.
- Preserve existing BTree serialization bytes, metadata compatibility, and query behavior.
- Keep validation for malformed serialized keys and invalid min/max metadata.
This is a preparatory refactoring. Bitmap global index format support and range/string fallback will be implemented separately.
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API in include dir or storage format or protocol -->
### Documentation
<!-- Does this change introduce a new feature -->
### Generative AI tooling
Generated-by: OpenAI Codex (GPT-5)
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(global-index): extract common sorted index components [paimon-cpp]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas merged PR #343:
URL: https://github.com/apache/paimon-cpp/pull/343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(global-index): extract common sorted index components [paimon-cpp]
Posted by "lszskye (via GitHub)" <gi...@apache.org>.
lszskye commented on code in PR #343:
URL: https://github.com/apache/paimon-cpp/pull/343#discussion_r4014099317
##########
src/paimon/common/global_index/sorted_index_file_meta.h:
##########
@@ -24,21 +24,22 @@
#include "paimon/common/memory/memory_slice_input.h"
#include "paimon/memory/bytes.h"
+#include "paimon/memory/memory_pool.h"
#include "paimon/result.h"
namespace paimon {
-/// Index metadata for each BTree index file.
+/// Manifest-level min/max metadata for one global index file.
Review Comment:
By the way, why `Manifest-level`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org