[jira] [Resolved] (HBASE-28114) Add more comments to explain why replication log queue could never be empty for normal replication queue

["Duo Zhang (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-28114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang resolved HBASE-28114.
-------------------------------
    Hadoop Flags: Reviewed
      Resolution: Fixed

Finally pushed to branch-2+.

Thanks [~Xiaolin Ha] for reviewing!

> Add more comments to explain why replication log queue could never be empty for normal replication queue
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-28114
>                 URL: https://issues.apache.org/jira/browse/HBASE-28114
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 2.6.0, 3.0.0-beta-1
>
>
> In HBASE-28037, [~Xiaolin Ha] found that there could be a very small window that even for a normal replication source, its queue could be empty.
> This is because we will only enqueue the wal file to the queue in postLogRoll, where the old WAL writer has already been closed, so if the replication is fast enough, we could reach the end of the queue before enqueuing the new wal file.
> The code for branch-2+ has been refactored a lot so we opened a new issue for fixing this.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)