[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15123: check for zipped files in import rules for upgrade check

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #15123:
URL: https://github.com/apache/airflow/pull/15123#discussion_r605430470



##########
File path: airflow/upgrade/rules/import_changes.py
##########
@@ -141,8 +141,9 @@ def _check_missing_providers(providers):
                 yield "Please install `{}`".format(dist_name)
 
     def check(self):
-        dag_folder = conf.get("core", "dags_folder")
-        files = list_py_file_paths(directory=dag_folder, include_examples=False)
+        dags_folder = conf.get("core", "dags_folder")
+        dags_folder = correct_maybe_zipped(dags_folder)
+        files = list_py_file_paths(directory=dags_folder, include_examples=False)
         files = [file for file in files if os.path.splitext(file)[1] == ".py"]

Review comment:
       This change is not working, I tested with a zip file and it didn't work.
   My suggestion is to work on the `files` variable, it contains all the files in the folder that has `.py` file in them. Both zipped files that has `.py` in them




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org