You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by Marshall Schor <ms...@schor.com> on 2018/12/20 16:18:58 UTC
how to handle pull requests for "mirrored" uima projects?
I'm looking for a little hand-holding re: using the apache mirrored github.
I can see there some pull requests for uimaj. I can open them and observe the diff.
Because these are just "mirrors", I think I can't do anything except to manually
copy these changes into an SVN set-up source, and then commit that. Is that
correct?
If I do that, is there something I do on the github mirror to indicate I've
"accepted" and "applied " the change?
Thanks. -Marshall
Re: how to handle pull requests for "mirrored" uima projects?
Posted by Peter Klügl <pe...@averbis.com>.
It is also an option to ask for a normal SVN patch until the project
switched to git. I think they will provide one (maybe not before the
holidays) :-)
Best,
Peter
Am 20.12.2018 um 17:18 schrieb Marshall Schor:
> I'm looking for a little hand-holding re: using the apache mirrored github.
>
> I can see there some pull requests for uimaj. I can open them and observe the diff.
>
> Because these are just "mirrors", I think I can't do anything except to manually
> copy these changes into an SVN set-up source, and then commit that. Is that
> correct?
>
> If I do that, is there something I do on the github mirror to indicate I've
> "accepted" and "applied " the change?
>
> Thanks. -Marshall
>
--
Peter Klügl
R&D Text Mining/Machine Learning
Averbis GmbH
Tennenbacher Str. 11
79106 Freiburg
Germany
Fon: +49 761 708 394 0
Fax: +49 761 708 394 10
Email: peter.kluegl@averbis.com
Web: https://averbis.com
Headquarters: Freiburg im Breisgau
Register Court: Amtsgericht Freiburg im Breisgau, HRB 701080
Managing Directors: Dr. med. Philipp Daumke, Dr. Kornél Markó
Re: how to handle pull requests for "mirrored" uima projects?
Posted by Richard Eckart de Castilho <re...@apache.org>.
We could see if it might be possible to set up a Jenkins job to build such PRs
so that you get some basic feedback from the CI before having to apply the patch
and building locally. I think it should be possible to do that even for mirrors.
-- Richard
Re: how to handle pull requests for "mirrored" uima projects?
Posted by Marshall Schor <ms...@schor.com>.
re: closing a pull request after committing the change to SVN.
The github help gives instructions on how to do this that are ineffective,
because they say to click the "close" button below the comment box at the
bottom, but there is no such button.
I'm guessing this is because I don't have permission to close the pull request,
although it seems like the creator of the pull request could.
Does this seem right, or am I missing something?
-Marshall
On 12/20/2018 2:19 PM, Richard Eckart de Castilho wrote:
> On 20. Dec 2018, at 17:18, Marshall Schor <ms...@schor.com> wrote:
>> I'm looking for a little hand-holding re: using the apache mirrored github.
>>
>> I can see there some pull requests for uimaj. I can open them and observe the diff.
>>
>> Because these are just "mirrors", I think I can't do anything except to manually
>> copy these changes into an SVN set-up source, and then commit that. Is that
>> correct?
> Well, you should be able to review and discuss the changes - make comments if necessary
> and ask for changes.
>
> But once the patch is ready, you'd have to download it and manually apply it to the SVN, yes.
>
>> If I do that, is there something I do on the github mirror to indicate I've
>> "accepted" and "applied " the change?
> You can leave a comment saying that it has been merged. The PR should contain a link to the
> corresponding Jira. It would also be possible to define a custom label like "Merged" to mark
> such PRs. But other than that, the only option is afaik to just close them once they are done.
>
> -- Richard
>
>
Re: how to handle pull requests for "mirrored" uima projects?
Posted by Richard Eckart de Castilho <re...@apache.org>.
On 20. Dec 2018, at 17:18, Marshall Schor <ms...@schor.com> wrote:
>
> I'm looking for a little hand-holding re: using the apache mirrored github.
>
> I can see there some pull requests for uimaj. I can open them and observe the diff.
>
> Because these are just "mirrors", I think I can't do anything except to manually
> copy these changes into an SVN set-up source, and then commit that. Is that
> correct?
Well, you should be able to review and discuss the changes - make comments if necessary
and ask for changes.
But once the patch is ready, you'd have to download it and manually apply it to the SVN, yes.
> If I do that, is there something I do on the github mirror to indicate I've
> "accepted" and "applied " the change?
You can leave a comment saying that it has been merged. The PR should contain a link to the
corresponding Jira. It would also be possible to define a custom label like "Merged" to mark
such PRs. But other than that, the only option is afaik to just close them once they are done.
-- Richard