You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by afs <gi...@git.apache.org> on 2017/06/28 10:35:15 UTC

[GitHub] jena pull request #267: JENA-1369: TDB cleanup

GitHub user afs opened a pull request:

    https://github.com/apache/jena/pull/267

    JENA-1369: TDB cleanup

    This PR is the result of having to investigate what was going on inside TDB1.
    
    There are no changes to TDB behaviour in this PR.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/afs/jena tdb-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #267
    
----
commit 0ab57c0467d6cdb43309629e399a8cc4bba87d2f
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-27T21:40:17Z

    Remove unused.

commit 91a65ad2a7e6e0d11dbd1672837b0addb5d12423
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-27T21:41:03Z

    Rename is dumpnodes

commit 053c06a937e0c2cdf4b344526a036a9e5c356a2e
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-27T21:41:38Z

    Remove out of date comment.

commit 9dc27c4ef2865c840555892f9ffa6ae714e6bfc6
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-27T21:42:13Z

    Make private as only used in this class.

commit 9d6c6e3c4436fa2f0f23f3bfa8415296015251ef
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-27T21:43:04Z

    Readonly enforcement wrapper.

commit e1abec9268bccc35fefa24dc135ea66e31bb0887
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-27T21:43:12Z

    Typo

commit b92ba1a56a011479aa6f3cfef556fc512c507fae
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-27T21:45:40Z

    Tidy up.

commit 3764a2aedd86e9ca0edd4faac1f36850074dd51d
Author: Andy Seaborne <an...@apache.org>
Date:   2017-06-28T08:28:57Z

    JENA-1369: Cleaning up TDB Transaction setup.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request #267: JENA-1369: TDB cleanup

Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on a diff in the pull request:

    https://github.com/apache/jena/pull/267#discussion_r124515375
  
    --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/transaction/DatasetBuilderTxn.java ---
    @@ -159,6 +160,22 @@ public BlockMgr buildBlockMgr(FileSet fileSet, String ext, IndexParams params) {
             }
         }
     
    +    // Object files currently, don't need journalling. Because they aer apend only, they 
    --- End diff --
    
    typo (aer/are) but not important. Internal comment only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request #267: JENA-1369: TDB cleanup

Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/267#discussion_r124516615
  
    --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/transaction/DatasetBuilderTxn.java ---
    @@ -159,6 +160,22 @@ public BlockMgr buildBlockMgr(FileSet fileSet, String ext, IndexParams params) {
             }
         }
     
    +    // Object files currently, don't need journalling. Because they aer apend only, they 
    --- End diff --
    
    Fixed!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jena pull request #267: JENA-1369: TDB cleanup

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jena/pull/267


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---