[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #449: [Feature] shuffle server report storage capability

[GitBox <gi...@apache.org>]

advancedxy commented on code in PR #449:
URL: https://github.com/apache/incubator-uniffle/pull/449#discussion_r1060505648


##########
proto/src/main/proto/Rss.proto:
##########
@@ -239,6 +239,7 @@ message ShuffleServerHeartBeatRequest {
   int32 eventNumInFlush = 5;
   repeated string tags = 6;
   google.protobuf.BoolValue isHealthy = 7;
+  map<string, LocalStorageInfo> localStorages = 21; // mount point to local storage info mapping.

Review Comment:
   > Maybe we should collect remote storage, too. The failure times of writing is also meaningful. So we should give a more comprehensive design.
   
   Yeah, remote storage info is also useful. Let me write a quick design doc and let's discuss there.
   
   > why not directly using repeated LocalStorageInfo localStorages
   
   For local storages, there might be multiple path pointing to the same mount point.  I'd like to do some deduplicate here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org