You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2016/11/04 06:37:41 UTC
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Hao Hao has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4945
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and add an allow_unsafe_replication_factor
master flag to make it possible for advanced user.s
Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
---
M src/kudu/client/client-test.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/4945/1
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] KUDU-1658: Reject CREATE TABLE ops with even replication factor
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1658: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 6:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4945/6/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
PS6, Line 120: table
nit: should be "Allow creating creating tables with an even replication factor."
PS6, Line 933: s. U
nit: should be ", unless master flag..."
PS6, Line 936: Reject CREATE TABLE with even replication "
: "factor
nit: doesn't match our normal style for user-facing error messages. I would say something like "illegal replication factor $0 (replication factor must be odd)"
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4945
to look at the new patch set (#5).
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and add an allow_unsafe_replication_factor
master flag to make it possible for advanced user.
Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tools/kudu-admin-test.cc
7 files changed, 58 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/4945/5
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4945/2//COMMIT_MSG
Commit Message:
PS2, Line 9:
nit: an extra space
http://gerrit.cloudera.org:8080/#/c/4945/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
PS2, Line 3932:
nit: per the styling guide, the indent is 2 spaces.
PS2, Line 3939: even replication
nit: even replication factor?
http://gerrit.cloudera.org:8080/#/c/4945/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
PS2, Line 119: ""
It would be nice to have a short description for this flag.
PS2, Line 120: TAG_FLAG(allow_unsafe_replication_factor
Does it make sense to mark it as advanced as well?
PS2, Line 884:
style: per current style guide, the regular indent is 2 spaces; do not use tabs.
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
LGTM, one nit.
http://gerrit.cloudera.org:8080/#/c/4945/5//COMMIT_MSG
Commit Message:
Line 7: Reject CREATE TABLE ops with even replication factor
If we have a JIRA filed for this issue/task, it's a good practice to start the COMMIT_MSG with jira number.
"KUDU-1658: Reject CREATE...."
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1658: Reject CREATE TABLE ops with even replication factor
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4945
to look at the new patch set (#7).
Change subject: KUDU-1658: Reject CREATE TABLE ops with even replication factor
......................................................................
KUDU-1658: Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and add an allow_unsafe_replication_factor
master flag to make it possible for advanced user.
Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/tools/kudu-admin-test.cc
8 files changed, 62 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/4945/7
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1658: Reject CREATE TABLE ops with even replication factor
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4945
to look at the new patch set (#6).
Change subject: KUDU-1658: Reject CREATE TABLE ops with even replication factor
......................................................................
KUDU-1658: Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and add an allow_unsafe_replication_factor
master flag to make it possible for advanced user.
Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/tools/kudu-admin-test.cc
8 files changed, 62 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/4945/6
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4945
to look at the new patch set (#3).
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and add an allow_unsafe_replication_factor
master flag to make it possible for advanced user.
Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tools/kudu-admin-test.cc
7 files changed, 41 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/4945/3
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1658: Reject CREATE TABLE ops with even replication factor
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1658: Reject CREATE TABLE ops with even replication factor
......................................................................
KUDU-1658: Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and add an allow_unsafe_replication_factor
master flag to make it possible for advanced user.
Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Reviewed-on: http://gerrit.cloudera.org:8080/4945
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/tools/kudu-admin-test.cc
8 files changed, 62 insertions(+), 15 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has uploaded a new patch set (#2).
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and add an allow_unsafe_replication_factor
master flag to make it possible for advanced user.
Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
---
M src/kudu/client/client-test.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/4945/2
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4945
to look at the new patch set (#4).
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and add an allow_unsafe_replication_factor
master flag to make it possible for advanced user.
Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/tools/kudu-admin-test.cc
7 files changed, 42 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/4945/4
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 2:
> Build Failed
>
> http://104.196.14.100/job/kudu-gerrit/4280/ : FAILURE
Looks like there's a few unit tests to fix :)
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4945/5//COMMIT_MSG
Commit Message:
Line 7: Reject CREATE TABLE ops with even replication factor
> If we have a JIRA filed for this issue/task, it's a good practice to start
+1
http://gerrit.cloudera.org:8080/#/c/4945/5/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
Line 898: return Status::InvalidArgument(Substitute("Reject CREATE TABLE with even replication "
Shouldn't this setup error with a MasterErrorPB?
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4945/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
PS2, Line 120: TAG_FLAG(allow_unsafe_replication_factor
> Does it make sense to mark it as advanced as well?
Based on the flag_tags.h comments "/ - "advanced":
// These flags are for advanced users or debugging purposes. While
// they aren't likely to be actively harmful (see "unsafe" below),
// they're also likely to be used only rarely and should be relegated
// to more detailed sections of documentation.
//
// - "unsafe":
// These flags are for internal use only (e.g. testing), and changing
// them away from the defaults may result in arbitrarily bad things
// happening. These flags are automatically excluded from user-facing
// documentation even if they are not also marked 'hidden'.
//
// Users must pass --unlock_unsafe_flags to use any of these
// flags."
It make sense just to mark it unsafe, since I think even replication factor is only for testing?
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 2:
Working on the fix..
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-1658: Reject CREATE TABLE ops with even replication factor
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Dinesh Bhat, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4945
to look at the new patch set (#8).
Change subject: KUDU-1658: Reject CREATE TABLE ops with even replication factor
......................................................................
KUDU-1658: Reject CREATE TABLE ops with even replication factor
Reject table creation with even replication factor,
and add an allow_unsafe_replication_factor
master flag to make it possible for advanced user.
Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
---
M src/kudu/client/client-test.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/tools/kudu-admin-test.cc
8 files changed, 62 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/4945/8
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-1658: Reject CREATE TABLE ops with even replication factor
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1658: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Reject CREATE TABLE ops with even replication factor
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Reject CREATE TABLE ops with even replication factor
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4945/4/src/kudu/integration-tests/delete_table-test.cc
File src/kudu/integration-tests/delete_table-test.cc:
PS4, Line 584:
nit: it seems a tab is used here instead of spaces.
http://gerrit.cloudera.org:8080/#/c/4945/4/src/kudu/integration-tests/tablet_copy-itest.cc
File src/kudu/integration-tests/tablet_copy-itest.cc:
PS4, Line 412: vector<string> ts_flags, master_flags;
: ts_flags.push_back("--enable_leader_failure_detection=false");
: master_flags.push_back("--catalog_manager_wait_for_new_tablets_to_elect_leader=false");
: master_flags.push_back("--allow_unsafe_replication_factor=true");
nit: while you at it, could you update this to use the initializer lists instead of push_back() calls?
http://gerrit.cloudera.org:8080/#/c/4945/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
PS2, Line 120: "Allow creating table with
> Based on the flag_tags.h comments "/ - "advanced":
ok, as I understand, with this semantics 'unsafe' is a stronger case of 'advanced', so no other specifiers are required.
http://gerrit.cloudera.org:8080/#/c/4945/4/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
PS4, Line 120:
nit: an extra space
--
To view, visit http://gerrit.cloudera.org:8080/4945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1674cc59cdfc2955d42fc5e4d8c0d962d9cc8e8e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes