You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/02/23 01:12:16 UTC
[GitHub] [helix] qqu0127 commented on a change in pull request #1967: Add Authorization Components to helix-rest
qqu0127 commented on a change in pull request #1967:
URL: https://github.com/apache/helix/pull/1967#discussion_r812486765
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/authValidator/DefaultAuthValidator.java
##########
@@ -0,0 +1,10 @@
+package org.apache.helix.rest.server.authValidator;
+
+import javax.ws.rs.container.ContainerRequestContext;
+
+
+public class DefaultAuthValidator implements AuthValidator {
+ public boolean validate(ContainerRequestContext request) {
+ return true;
+ }
+}
Review comment:
Do we have a plan to add "real" validators?
I might be missing context, but It feels a little weird to have a standalone default class, which turns out to be a noop. A default method impl may be better depends on your use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org