You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "abderrahim (via GitHub)" <gi...@apache.org> on 2025/09/10 11:34:02 UTC
[PR] _frontend: allow showing the element kind in `bst show` [buildstream]
abderrahim opened a new pull request, #2058:
URL: https://github.com/apache/buildstream/pull/2058
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] _frontend: allow showing the element kind in `bst show` [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi commented on code in PR #2058:
URL: https://github.com/apache/buildstream/pull/2058#discussion_r2337004259
##########
src/buildstream/_frontend/widget.py:
##########
@@ -355,6 +355,7 @@ def show_pipeline(self, dependencies, format_):
description = " ".join(element._description.splitlines())
line = p.fmt_subst(line, "name", element._get_full_name(), fg="blue", bold=True)
+ line = p.fmt_subst(line, "kind", element.get_kind(), fg="blue", bold=True)
Review Comment:
Nit: I think I would drop the `bold` and/or the color.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] _frontend: allow showing the element kind in `bst show` [buildstream]
Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on code in PR #2058:
URL: https://github.com/apache/buildstream/pull/2058#discussion_r2337576179
##########
src/buildstream/_frontend/widget.py:
##########
@@ -355,6 +355,7 @@ def show_pipeline(self, dependencies, format_):
description = " ".join(element._description.splitlines())
line = p.fmt_subst(line, "name", element._get_full_name(), fg="blue", bold=True)
+ line = p.fmt_subst(line, "kind", element.get_kind(), fg="blue", bold=True)
Review Comment:
Dropped the bold (and changed the color).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] _frontend: allow showing the element kind in `bst show` [buildstream]
Posted by "juergbi (via GitHub)" <gi...@apache.org>.
juergbi merged PR #2058:
URL: https://github.com/apache/buildstream/pull/2058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org