You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/26 08:36:08 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #17293: [improve][broker] Add a message to a NullPointerException created in ManagedLedgerImpl

lhotari opened a new pull request, #17293:
URL: https://github.com/apache/pulsar/pull/17293

   ### Motivation
   
   - a NPE with no description is confusing
   
   Seeing this in logs of org.apache.pulsar.client.api.SubscriptionMessageDispatchThrottlingTest#testMultiLevelDispatch
   ```
   2022-08-26T11:18:10,532 - ERROR - [broker-topic-workers-OrderedExecutor-3-0:SafeRunnable@38] - Unexpected throwable caught
   java.lang.NullPointerException: null
   ```
   
   ### Modifications
   
   Add a description to the NPE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #17293: [improve][broker] Add a message to a NullPointerException created in ManagedLedgerImpl

Posted by GitBox <gi...@apache.org>.

lhotari merged PR #17293:
URL: https://github.com/apache/pulsar/pull/17293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on pull request #17293: [improve][broker] Add a message to a NullPointerException created in ManagedLedgerImpl

Posted by GitBox <gi...@apache.org>.

merlimat commented on PR #17293:
URL: https://github.com/apache/pulsar/pull/17293#issuecomment-1230684441

   @lhotari While the `throw new NullPointerException()` is clearly not good, I think the logline is generated when the exception is repeated multiple times. The JVM will omit the stack traces and the message after a while.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org