You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/08 16:31:54 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37442: [SPARK-40008][SQL] Support casting integrals to intervals in ANSI mode
MaxGekk opened a new pull request, #37442:
URL: https://github.com/apache/spark/pull/37442
### What changes were proposed in this pull request?
In the PR, I propose to support casting of the integral type: `TINYINT`, `SMALLINT`, `INT`, `BIGINT` to ANSI interval types.
### Why are the changes needed?
To conform the SQL standard which allows such casting:
<img width="801" alt="173228149-17e1fbaa-c095-4eb7-bb3b-81a3f9c91928" src="https://user-images.githubusercontent.com/1580697/183467069-73b2b4e4-6c34-4395-beb8-f1d721483f43.png">
### Does this PR introduce _any_ user-facing change?
No, it extends existing behavior.
### How was this patch tested?
By running new tests:
```
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z cast.sql"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37442: [SPARK-40008][SQL] Support casting of integrals to ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37442:
URL: https://github.com/apache/spark/pull/37442#issuecomment-1208934991
Merging to master. Thank you, @HyukjinKwon @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37442: [SPARK-40008][SQL] Support casting of integrals to ANSI intervals
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37442: [SPARK-40008][SQL] Support casting of integrals to ANSI intervals
URL: https://github.com/apache/spark/pull/37442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org