You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jscheid <gi...@git.apache.org> on 2015/09/25 15:58:46 UTC

[GitHub] activemq-artemis pull request: ARTEMIS-229 validate user and role ...

GitHub user jscheid opened a pull request:

    https://github.com/apache/activemq-artemis/pull/175

    ARTEMIS-229 validate user and role with address

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/waysact/activemq-artemis ARTEMIS-229-validate-user-address

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/175.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #175
    
----
commit 6890f126cbd3df6ef0b096d4f1256ef540b9b36f
Author: Julian Scheid <ju...@gmail.com>
Date:   2015-09-25T12:08:28Z

    ARTEMIS-229 validate user and role with address

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-229 validate user and role ...

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/175#issuecomment-143240576
  
    ok, looks like that's the standard way then.. I was being Old Fashioned :)
    
    will merge this soon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-229 validate user and role ...

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/175#issuecomment-143235768
  
    Looks good... I am not sure I like the name ActiveMQSecurityManager2 though...
    
    But I am failing to find a better one. I thought about 
    - ActiveMQSecurityManagerExt
    - ActiveMQSecurityManagerAddress
    - ActiveMQSecurityManagerV2   (this one probably makes it a better sense... the V makes it clear it's a versioning thing, and we would deprecate the previous one)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-229 validate user and role ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/175


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-229 validate user and role ...

Posted by jmesnil <gi...@git.apache.org>.
Github user jmesnil commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/175#issuecomment-143239217
  
    fwiw, Eclipse has the best document about evolving Java API and they use the `2` version: https://wiki.eclipse.org/Evolving_Java-based_APIs_3#.222.22_Convention


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request: ARTEMIS-229 validate user and role ...

Posted by jscheid <gi...@git.apache.org>.
Github user jscheid commented on the pull request:

    https://github.com/apache/activemq-artemis/pull/175#issuecomment-143236069
  
    It was inspired by http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/collect/Collections2.html
    
    But I don't care what it's called, let me know what name you'd prefer and I'm happy to change it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---