[GitHub] [incubator-superset] suddjian edited a comment on issue #11542: [dashboard filter indicator] Dashboard does not apply filter

[GitBox <gi...@apache.org>]

suddjian edited a comment on issue #11542:
URL: https://github.com/apache/incubator-superset/issues/11542#issuecomment-721942157


   Nice! To narrow this down a little more, if you remove the this check from `shouldComponentUpdate`, it works
   
   ```
   if (nextProps.mountedParent === null) {
     return false;
   }
   ```
   
   It looks like the code responsible for focusing the filter when you click on it in the indicator is the source of the problem. `dashboardState.mountedTab` in redux is being set to `null` when it shouldn't be.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org