You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/06/03 22:11:12 UTC

[GitHub] [servicecomb-java-chassis] jungan21 opened a new pull request #1815: [SCB-1971] minor change to fix an issue

jungan21 opened a new pull request #1815:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1815


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1815: [SCB-1971] minor change to fix an issue

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1815:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1815


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] wujimin commented on a change in pull request #1815: [SCB-1971] minor change to fix an issue

Posted by GitBox <gi...@apache.org>.
wujimin commented on a change in pull request #1815:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1815#discussion_r434933441



##########
File path: service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/ZeroConfigRegistration.java
##########
@@ -48,8 +48,8 @@
   private ZeroConfigClient zeroConfigClient = ZeroConfigClient.INSTANCE;
 
   // registration objects
-  private Microservice selfMicroservice;
-  private MicroserviceInstance selfMicroserviceInstance;
+  private static Microservice selfMicroservice;

Review comment:
       better not to use static variables




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] coveralls commented on pull request #1815: [SCB-1971] minor change to fix an issue

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1815:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1815#issuecomment-638507643


   
   [![Coverage Status](https://coveralls.io/builds/31224825/badge)](https://coveralls.io/builds/31224825)
   
   Coverage increased (+0.01%) to 86.4% when pulling **79d131be809b890fd8d5deeaabb45b2d67ffb330 on jungan21:master** into **9798ca830d57f503e8b5eac576863b0b31783727 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1815: [SCB-1971] minor change to fix an issue

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1815:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1815#issuecomment-638507643


   
   [![Coverage Status](https://coveralls.io/builds/31229021/badge)](https://coveralls.io/builds/31229021)
   
   Coverage decreased (-0.001%) to 86.385% when pulling **24dc6c088ad5351642f4753227d7681d89729e53 on jungan21:master** into **9798ca830d57f503e8b5eac576863b0b31783727 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] jungan21 commented on a change in pull request #1815: [SCB-1971] minor change to fix an issue

Posted by GitBox <gi...@apache.org>.
jungan21 commented on a change in pull request #1815:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1815#discussion_r434963440



##########
File path: service-registry/registry-zero-config/src/main/java/org/apache/servicecomb/zeroconfig/ZeroConfigRegistration.java
##########
@@ -48,8 +48,8 @@
   private ZeroConfigClient zeroConfigClient = ZeroConfigClient.INSTANCE;
 
   // registration objects
-  private Microservice selfMicroservice;
-  private MicroserviceInstance selfMicroserviceInstance;
+  private static Microservice selfMicroservice;

Review comment:
       changed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] coveralls edited a comment on pull request #1815: [SCB-1971] minor change to fix an issue

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #1815:
URL: https://github.com/apache/servicecomb-java-chassis/pull/1815#issuecomment-638507643


   
   [![Coverage Status](https://coveralls.io/builds/31229766/badge)](https://coveralls.io/builds/31229766)
   
   Coverage decreased (-0.007%) to 86.38% when pulling **24dc6c088ad5351642f4753227d7681d89729e53 on jungan21:master** into **9798ca830d57f503e8b5eac576863b0b31783727 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org