You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/06 08:03:14 UTC

[GitHub] [pulsar] gaozhangmin opened a new pull request, #16414: [fix]Fix the way of detecting nar archive file

gaozhangmin opened a new pull request, #16414:
URL: https://github.com/apache/pulsar/pull/16414

   ### Motivation
   Fixes #16397
   
   
   ### Modifications
   Check if `META-INF/MANIFEST.MF` file contains content `Nar-Id`
   
   
   ### Documentation
     
   - [ ] `doc-not-needed` 
   (Please explain why)
     
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] gaozhangmin closed pull request #16414: [fix][function]Fix the way of detecting nar archive file

Posted by GitBox <gi...@apache.org>.
gaozhangmin closed pull request #16414: [fix][function]Fix the way of detecting nar archive file
URL: https://github.com/apache/pulsar/pull/16414


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] shibd commented on pull request #16414: [fix][function]Fix the way of detecting nar archive file

Posted by GitBox <gi...@apache.org>.
shibd commented on PR #16414:
URL: https://github.com/apache/pulsar/pull/16414#issuecomment-1176239607

   Link issue question: https://github.com/apache/pulsar/issues/16397#issuecomment-1176031918


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] cbornet commented on pull request #16414: [fix][function]Fix the way of detecting nar archive file

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16414:
URL: https://github.com/apache/pulsar/pull/16414#issuecomment-1325161465

   Why was it closed ? Maybe we could detect of we have `Nar-Id` OR `bundled-dependencies` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] eolivelli commented on pull request #16414: [fix][function]Fix the way of detecting nar archive file

Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #16414:
URL: https://github.com/apache/pulsar/pull/16414#issuecomment-1176134578

   @cbornet
   PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #16414: [fix]Fix the way of detecting nar archive file

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16414:
URL: https://github.com/apache/pulsar/pull/16414#issuecomment-1175912717

   @gaozhangmin Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org