[GitHub] [hbase] Apache9 commented on a diff in pull request #4586: HBASE-27161 Improve TestMultiRespectsLimits

[GitBox <gi...@apache.org>]

Apache9 commented on code in PR #4586:
URL: https://github.com/apache/hbase/pull/4586#discussion_r912497961


##########
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMultiRespectsLimits.java:
##########
@@ -150,10 +150,10 @@ public void testBlockMultiLimits() throws Exception {
       Bytes.toBytes("5"), // Buffer
     };
 
-    // Set the value size so that one result will be less than the MAX_SIE
+    // Set the value size so that one result will be less than the MAX_SIZE
     // however the block being reference will be larger than MAX_SIZE.
     // This should cause the regionserver to try and send a result immediately.
-    byte[] value = new byte[MAX_SIZE - 100];
+    byte[] value = new byte[MAX_SIZE / 2];

Review Comment:
   I wonder whether / 2 is enough? If it is too big, then testBlockMultiLimits will be the same with testMultiLimits?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org