You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2012/08/15 20:57:37 UTC
svn commit: r1373570 - in /tomcat/trunk/java/org/apache/coyote/ajp:
AbstractAjpProcessor.java AjpAprProcessor.java AjpAprProtocol.java
AjpMessage.java AjpNioProcessor.java AjpNioProtocol.java AjpProtocol.java
Author: markt
Date: Wed Aug 15 18:57:37 2012
New Revision: 1373570
URL: http://svn.apache.org/viewvc?rev=1373570&view=rev
Log:
Clean-up: final markers (UCDetector)
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProtocol.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java?rev=1373570&r1=1373569&r2=1373570&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java Wed Aug 15 18:57:37 2012
@@ -137,7 +137,7 @@ public abstract class AbstractAjpProcess
/**
* AJP packet size.
*/
- protected int packetSize;
+ protected final int packetSize;
/**
* Header message. Note that this header is merely the one used during the
@@ -145,25 +145,25 @@ public abstract class AbstractAjpProcess
* request header. It will stay unchanged during the processing of the whole
* request.
*/
- protected AjpMessage requestHeaderMessage = null;
+ protected final AjpMessage requestHeaderMessage;
/**
* Message used for response composition.
*/
- protected AjpMessage responseMessage = null;
+ protected final AjpMessage responseMessage;
/**
* Body message.
*/
- protected AjpMessage bodyMessage = null;
+ protected final AjpMessage bodyMessage;
/**
* Body message.
*/
- protected MessageBytes bodyBytes = MessageBytes.newInstance();
+ protected final MessageBytes bodyBytes = MessageBytes.newInstance();
/**
@@ -181,13 +181,13 @@ public abstract class AbstractAjpProcess
/**
* Temp message bytes used for processing.
*/
- protected MessageBytes tmpMB = MessageBytes.newInstance();
+ protected final MessageBytes tmpMB = MessageBytes.newInstance();
/**
* Byte chunk for certs.
*/
- protected MessageBytes certificates = MessageBytes.newInstance();
+ protected final MessageBytes certificates = MessageBytes.newInstance();
/**
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java?rev=1373570&r1=1373569&r2=1373570&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java Wed Aug 15 18:57:37 2012
@@ -84,13 +84,13 @@ public class AjpAprProcessor extends Abs
/**
* Direct buffer used for input.
*/
- protected ByteBuffer inputBuffer = null;
+ protected final ByteBuffer inputBuffer;
/**
* Direct buffer used for output.
*/
- protected ByteBuffer outputBuffer = null;
+ protected final ByteBuffer outputBuffer;
// --------------------------------------------------------- Public Methods
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java?rev=1373570&r1=1373569&r2=1373570&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java Wed Aug 15 18:57:37 2012
@@ -77,7 +77,7 @@ public class AjpAprProtocol extends Abst
/**
* Connection handler for AJP.
*/
- private AjpConnectionHandler cHandler;
+ private final AjpConnectionHandler cHandler;
// --------------------------------------------------------- Public Methods
@@ -106,7 +106,7 @@ public class AjpAprProtocol extends Abst
extends AbstractAjpConnectionHandler<Long,AjpAprProcessor>
implements Handler {
- protected AjpAprProtocol proto;
+ protected final AjpAprProtocol proto;
public AjpConnectionHandler(AjpAprProtocol proto) {
this.proto = proto;
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java?rev=1373570&r1=1373569&r2=1373570&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpMessage.java Wed Aug 15 18:57:37 2012
@@ -64,7 +64,7 @@ public class AjpMessage {
/**
* Fixed size buffer.
*/
- protected byte buf[] = null;
+ protected final byte buf[];
/**
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java?rev=1373570&r1=1373569&r2=1373570&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java Wed Aug 15 18:57:37 2012
@@ -76,7 +76,7 @@ public class AjpNioProcessor extends Abs
/**
* Selector pool for the associated endpoint.
*/
- protected NioSelectorPool pool;
+ protected final NioSelectorPool pool;
// --------------------------------------------------------- Public Methods
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProtocol.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProtocol.java?rev=1373570&r1=1373569&r2=1373570&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProtocol.java Wed Aug 15 18:57:37 2012
@@ -74,7 +74,7 @@ public class AjpNioProtocol extends Abst
/**
* Connection handler for AJP.
*/
- private AjpConnectionHandler cHandler;
+ private final AjpConnectionHandler cHandler;
// ----------------------------------------------------- JMX related methods
@@ -92,7 +92,7 @@ public class AjpNioProtocol extends Abst
extends AbstractAjpConnectionHandler<NioChannel, AjpNioProcessor>
implements Handler {
- protected AjpNioProtocol proto;
+ protected final AjpNioProtocol proto;
public AjpConnectionHandler(AjpNioProtocol proto) {
this.proto = proto;
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java?rev=1373570&r1=1373569&r2=1373570&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java Wed Aug 15 18:57:37 2012
@@ -71,7 +71,7 @@ public class AjpProtocol extends Abstrac
/**
* Connection handler for AJP.
*/
- private AjpConnectionHandler cHandler;
+ private final AjpConnectionHandler cHandler;
// ----------------------------------------------------- JMX related methods
@@ -89,7 +89,7 @@ public class AjpProtocol extends Abstrac
extends AbstractAjpConnectionHandler<Socket,AjpProcessor>
implements Handler {
- protected AjpProtocol proto;
+ protected final AjpProtocol proto;
public AjpConnectionHandler(AjpProtocol proto) {
this.proto = proto;
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org