You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/02/08 13:44:29 UTC
[GitHub] [hop] shlxue opened a new pull request #1343: HOP-3713 Fixed BlockingRowSet high cpu, support dynamic timeout when get row from InputRowSet
shlxue opened a new pull request #1343:
URL: https://github.com/apache/hop/pull/1343
Replace [PR-1305](https://github.com/apache/hop/pull/1305).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1343: HOP-3713 Fixed BlockingRowSet high cpu, support dynamic timeout when get row from InputRowSet
Posted by GitBox <gi...@apache.org>.
shlxue commented on pull request #1343:
URL: https://github.com/apache/hop/pull/1343#issuecomment-1040379492
I will fix this problem later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1343: HOP-3713 Fixed BlockingRowSet high cpu, support dynamic timeout when get row from InputRowSet
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #1343:
URL: https://github.com/apache/hop/pull/1343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] mattcasters commented on pull request #1343: HOP-3713 Fixed BlockingRowSet high cpu, support dynamic timeout when get row from InputRowSet
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #1343:
URL: https://github.com/apache/hop/pull/1343#issuecomment-1040036591
The changes caused a few of our integration tests to fail unfortunately...
https://ci-builds.apache.org/job/Hop/job/Hop-integration-tests/537/testReport/junit/(root)/transforms/0001_add_sequence/
https://ci-builds.apache.org/job/Hop/job/Hop-integration-tests/537/testReport/junit/(root)/partitioning/0004_copies_repartitioning/
java.lang.IllegalArgumentException: Removed a input steam, before switch next stream
at org.apache.hop.core.util.Assert.assertTrue(Assert.java:77)
at org.apache.hop.pipeline.transform.DynamicWaitTimes$MultiStreamStatus.remove(DynamicWaitTimes.java:124)
at org.apache.hop.pipeline.transform.BaseTransform.handleGetRow(BaseTransform.java:1622)
at org.apache.hop.pipeline.transform.BaseTransform.access$100(BaseTransform.java:116)
at org.apache.hop.pipeline.transform.BaseTransform$DefaultRowHandler.getRow(BaseTransform.java:3693)
at org.apache.hop.pipeline.transform.BaseTransform.getRow(BaseTransform.java:1498)
at org.apache.hop.pipeline.transforms.writetolog.WriteToLog.processRow(WriteToLog.java:52)
at org.apache.hop.pipeline.transform.RunThread.run(RunThread.java:58)
at java.lang.Thread.run(Thread.java:748)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] mattcasters commented on pull request #1343: HOP-3713 Fixed BlockingRowSet high cpu, support dynamic timeout when get row from InputRowSet
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #1343:
URL: https://github.com/apache/hop/pull/1343#issuecomment-1040036591
The changes caused a few of our integration tests to fail unfortunately...
https://ci-builds.apache.org/job/Hop/job/Hop-integration-tests/537/testReport/junit/(root)/transforms/0001_add_sequence/
https://ci-builds.apache.org/job/Hop/job/Hop-integration-tests/537/testReport/junit/(root)/partitioning/0004_copies_repartitioning/
java.lang.IllegalArgumentException: Removed a input steam, before switch next stream
at org.apache.hop.core.util.Assert.assertTrue(Assert.java:77)
at org.apache.hop.pipeline.transform.DynamicWaitTimes$MultiStreamStatus.remove(DynamicWaitTimes.java:124)
at org.apache.hop.pipeline.transform.BaseTransform.handleGetRow(BaseTransform.java:1622)
at org.apache.hop.pipeline.transform.BaseTransform.access$100(BaseTransform.java:116)
at org.apache.hop.pipeline.transform.BaseTransform$DefaultRowHandler.getRow(BaseTransform.java:3693)
at org.apache.hop.pipeline.transform.BaseTransform.getRow(BaseTransform.java:1498)
at org.apache.hop.pipeline.transforms.writetolog.WriteToLog.processRow(WriteToLog.java:52)
at org.apache.hop.pipeline.transform.RunThread.run(RunThread.java:58)
at java.lang.Thread.run(Thread.java:748)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] mattcasters commented on pull request #1343: HOP-3713 Fixed BlockingRowSet high cpu, support dynamic timeout when get row from InputRowSet
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #1343:
URL: https://github.com/apache/hop/pull/1343#issuecomment-1036014449
I'm starting the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1343: HOP-3713 Fixed BlockingRowSet high cpu, support dynamic timeout when get row from InputRowSet
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #1343:
URL: https://github.com/apache/hop/pull/1343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] mattcasters commented on pull request #1343: HOP-3713 Fixed BlockingRowSet high cpu, support dynamic timeout when get row from InputRowSet
Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #1343:
URL: https://github.com/apache/hop/pull/1343#issuecomment-1036365159
I've been running performance tests with on the PR and everything looks really good even for the high-paced worst-case scenarios I could come up with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1343: HOP-3713 Fixed BlockingRowSet high cpu, support dynamic timeout when get row from InputRowSet
Posted by GitBox <gi...@apache.org>.
shlxue commented on pull request #1343:
URL: https://github.com/apache/hop/pull/1343#issuecomment-1040379492
I will fix this problem later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org