You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by Jörn Kottmann <ko...@gmail.com> on 2011/06/06 23:18:52 UTC
Re: svn commit: r1132775 - /incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
Please mention the jira issue in the comment,
usually we do like this:
OPENNLP-154 Removed commented out code I forgot to nix before.
I will add it, then it is linked to the issue.
Jörn
On 6/6/11 11:14 PM, jbaldrid@apache.org wrote:
> Author: jbaldrid
> Date: Mon Jun 6 21:14:13 2011
> New Revision: 1132775
>
> URL: http://svn.apache.org/viewvc?rev=1132775&view=rev
> Log:
> Removed commented out code I forgot to nix before.
>
> Modified:
> incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
>
> Modified: incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
> URL: http://svn.apache.org/viewvc/incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java?rev=1132775&r1=1132774&r2=1132775&view=diff
> ==============================================================================
> --- incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java (original)
> +++ incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java Mon Jun 6 21:14:13 2011
> @@ -112,13 +112,6 @@ public class PerceptronModel extends Abs
> normal += prior[oid];
> }
>
> - //for (int oid = 0; oid< numOutcomes; oid++)
> - // prior[oid] = Math.exp(prior[oid]/maxPrior);
> - //
> - //double normal = 0.0;
> - //for (int oid = 0; oid< numOutcomes; oid++)
> - // normal += prior[oid];
> -
> for (int oid = 0; oid< numOutcomes; oid++)
> prior[oid] /= normal;
> }
>
>
Re: svn commit: r1132775 - /incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
Posted by Jason Baldridge <ja...@gmail.com>.
On Mon, Jun 6, 2011 at 4:28 PM, Jörn Kottmann <ko...@gmail.com> wrote:
> On 6/6/11 11:22 PM, Jason Baldridge wrote:
>
>> Sorry -- I added it to the substantial change that I checked in before,
>> but
>> thought this was too inconsequential to bother with.
>>
>
> I either put the tag in front or write "No Jira". Anyway in your case it
> was actually
> related to the change which you did before.
>
> Okay, will do that in future.
> I edited you comment, you can now see all changes related to the issue
> here:
>
> https://issues.apache.org/jira/browse/OPENNLP-154?page=com.atlassian.jira.plugin.ext.subversion%3Asubversion-commits-tabpanel#issue-tabs
>
> The last change is still missing, but will be appear there soon.
>
> Do you know about more issues we have with the perceptron code?
>
>
Looking into it now.
-Jason
--
Jason Baldridge
Assistant Professor, Department of Linguistics
The University of Texas at Austin
http://www.jasonbaldridge.com
http://twitter.com/jasonbaldridge
Re: svn commit: r1132775 - /incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
Posted by Jörn Kottmann <ko...@gmail.com>.
On 6/6/11 11:22 PM, Jason Baldridge wrote:
> Sorry -- I added it to the substantial change that I checked in before, but
> thought this was too inconsequential to bother with.
I either put the tag in front or write "No Jira". Anyway in your case it
was actually
related to the change which you did before.
I edited you comment, you can now see all changes related to the issue here:
https://issues.apache.org/jira/browse/OPENNLP-154?page=com.atlassian.jira.plugin.ext.subversion%3Asubversion-commits-tabpanel#issue-tabs
The last change is still missing, but will be appear there soon.
Do you know about more issues we have with the perceptron code?
Jörn
Re: svn commit: r1132775 - /incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
Posted by Jason Baldridge <ja...@gmail.com>.
Sorry -- I added it to the substantial change that I checked in before, but
thought this was too inconsequential to bother with.
On Mon, Jun 6, 2011 at 4:18 PM, Jörn Kottmann <ko...@gmail.com> wrote:
> Please mention the jira issue in the comment,
> usually we do like this:
> OPENNLP-154 Removed commented out code I forgot to nix before.
>
> I will add it, then it is linked to the issue.
>
> Jörn
>
> On 6/6/11 11:14 PM, jbaldrid@apache.org wrote:
>
>> Author: jbaldrid
>> Date: Mon Jun 6 21:14:13 2011
>> New Revision: 1132775
>>
>> URL: http://svn.apache.org/viewvc?rev=1132775&view=rev
>> Log:
>> Removed commented out code I forgot to nix before.
>>
>> Modified:
>>
>> incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
>>
>> Modified:
>> incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
>> URL:
>> http://svn.apache.org/viewvc/incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java?rev=1132775&r1=1132774&r2=1132775&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
>> (original)
>> +++
>> incubator/opennlp/trunk/opennlp-maxent/src/main/java/opennlp/perceptron/PerceptronModel.java
>> Mon Jun 6 21:14:13 2011
>> @@ -112,13 +112,6 @@ public class PerceptronModel extends Abs
>> normal += prior[oid];
>> }
>>
>> - //for (int oid = 0; oid< numOutcomes; oid++)
>> - // prior[oid] = Math.exp(prior[oid]/maxPrior);
>> - //
>> - //double normal = 0.0;
>> - //for (int oid = 0; oid< numOutcomes; oid++)
>> - // normal += prior[oid];
>> -
>> for (int oid = 0; oid< numOutcomes; oid++)
>> prior[oid] /= normal;
>> }
>>
>>
>>
>
--
Jason Baldridge
Assistant Professor, Department of Linguistics
The University of Texas at Austin
http://www.jasonbaldridge.com
http://twitter.com/jasonbaldridge