You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/17 08:12:54 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #39107: [SPARK-41559][INFRA] Reenable Codecov report in the scheduled job

HyukjinKwon opened a new pull request, #39107:
URL: https://github.com/apache/spark/pull/39107

   ### What changes were proposed in this pull request?
   
   This PR is a kind of a followup of https://github.com/apache/spark/pull/36940 which fixes a mistake of replacing `inputs.type`.
   
   This PR changes it to use `PYSPARK_CODECOV` that's defined from https://github.com/apache/spark/blob/353df517f4d37aabbf807638385b0ab92dd95397/.github/workflows/build_coverage.yml#L39.
   
   Similar approach is being used in https://github.com/apache/spark/blob/353df517f4d37aabbf807638385b0ab92dd95397/.github/workflows/build_ansi.yml#L39 with https://github.com/apache/spark/blob/919e556d182f86b3e1e22cd05a546e0f2fc3e307/.github/workflows/build_and_test.yml#L797
   
   ### Why are the changes needed?
   
   To recover the Codecov site. It stopped working for few months (https://app.codecov.io/gh/apache/spark).
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   Will monitor the test cases. I am sure it works :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #39107: [SPARK-41559][INFRA] Reenable Codecov report in the scheduled job

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39107:
URL: https://github.com/apache/spark/pull/39107#issuecomment-1356113858

   cc @Yikun mind taking a quick look please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #39107: [SPARK-41559][INFRA] Recover Codecov report in the scheduled job

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39107:
URL: https://github.com/apache/spark/pull/39107#issuecomment-1356183214

   Thanks guys.
   
   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] grundprinzip commented on pull request #39107: [SPARK-41559][INFRA] Recover Codecov report in the scheduled job

Posted by GitBox <gi...@apache.org>.
grundprinzip commented on PR #39107:
URL: https://github.com/apache/spark/pull/39107#issuecomment-1356147575

   LGTM thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #39107: [SPARK-41559][INFRA] Recover Codecov report in the scheduled job

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39107: [SPARK-41559][INFRA] Recover Codecov report in the scheduled job
URL: https://github.com/apache/spark/pull/39107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org