You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "visortelle (via GitHub)" <gi...@apache.org> on 2023/02/02 16:01:28 UTC
[GitHub] [pulsar] visortelle opened a new issue, #19406: [Doc] "pulsar-admin schemas delete" description is confusing
visortelle opened a new issue, #19406:
URL: https://github.com/apache/pulsar/issues/19406
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### What issue do you find in Pulsar docs?
Documentation tells me that all schema versions will be deleted. That's indeed how it works now.
<img width="845" alt="Screenshot 2023-02-02 at 4 58 09 PM" src="https://user-images.githubusercontent.com/9302460/216375269-690c8d1f-1259-45cc-9bf8-703eb2a2f166.png">
Pulsar admin tells me that only the latest schema will be deleted.
<img width="481" alt="Screenshot 2023-02-02 at 4 57 15 PM" src="https://user-images.githubusercontent.com/9302460/216374991-f8a1e0db-d230-4235-beff-dcef89eb9543.png">
https://github.com/apache/pulsar/blob/81af293c842c1fc7f42e13ac4203f287e4b619bb/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java#L77
I'm confused. Is it a mistake, or does "latest schema" doesn't mean "latest schema version"?
It's easy to misunderstand it and delete all schemas accidentally.
### What is your suggestion?
Make the pulsar-admin flag description more descriptive.
### Any reference?
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on issue #19406: [Doc] "pulsar-admin schemas delete" description is confusing
Posted by "momo-jun (via GitHub)" <gi...@apache.org>.
momo-jun commented on issue #19406:
URL: https://github.com/apache/pulsar/issues/19406#issuecomment-1414798290
@congbobo184 @Anonymitaet correct, it's by design. The admin API category is a central reference place so we put Schema-related admin API in there and only left a link in the feature content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on issue #19406: [Doc] "pulsar-admin schemas delete" description is confusing
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on issue #19406:
URL: https://github.com/apache/pulsar/issues/19406#issuecomment-1414674123
Another issue found in the Schema doc, the items in red are not shown on the sidebar, is it an intended behaviour?
<img width="1531" alt="image" src="https://user-images.githubusercontent.com/50226895/216496391-c5efe478-a4cb-4097-af16-daee7501ac12.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on issue #19406: [Doc] "pulsar-admin schemas delete" description is confusing
Posted by "congbobo184 (via GitHub)" <gi...@apache.org>.
congbobo184 commented on issue #19406:
URL: https://github.com/apache/pulsar/issues/19406#issuecomment-1414732964
> Another issue found in the Schema doc, the items in red are not shown on the sidebar, is it an intended behaviour? <img alt="image" width="1531" src="https://user-images.githubusercontent.com/50226895/216496391-c5efe478-a4cb-4097-af16-daee7501ac12.png">
it should be a intended behavior, manage schema move to the Admin API
@momo-jun right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed issue #19406: [Doc] "pulsar-admin schemas delete" description is confusing
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed issue #19406: [Doc] "pulsar-admin schemas delete" description is confusing
URL: https://github.com/apache/pulsar/issues/19406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on issue #19406: [Doc] "pulsar-admin schemas delete" description is confusing
Posted by "congbobo184 (via GitHub)" <gi...@apache.org>.
congbobo184 commented on issue #19406:
URL: https://github.com/apache/pulsar/issues/19406#issuecomment-1414726343
https://github.com/apache/pulsar/pull/19411 will fix the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on issue #19406: [Doc] "pulsar-admin schemas delete" description is confusing
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on issue #19406:
URL: https://github.com/apache/pulsar/issues/19406#issuecomment-1414663543
Hi @congbobo184 as we discussed just now, can you test this? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org