You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/10 20:02:00 UTC

[jira] [Commented] (DISPATCH-1311) Move the qdr_delivery_t code to a dedicated file (reorganization)

    [ https://issues.apache.org/jira/browse/DISPATCH-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814836#comment-16814836 ] 

ASF GitHub Bot commented on DISPATCH-1311:
------------------------------------------

kgiusti commented on pull request #489: DISPATCH-1311: move qdr_delivery_t API to its own source files
URL: https://github.com/apache/qpid-dispatch/pull/489
 
 
   This patch merely moves code and does some renaming of functions.  No
   changes to actual functionality have occurred - it is simply a
   reorganization of code layout.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Move the qdr_delivery_t code to a dedicated file (reorganization)
> -----------------------------------------------------------------
>
>                 Key: DISPATCH-1311
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1311
>             Project: Qpid Dispatch
>          Issue Type: Sub-task
>          Components: Router Node
>    Affects Versions: 1.6.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>            Priority: Major
>              Labels: delivery-refactor
>
> Let's start the process of moving delivery settlement and disposition handling out of the core thread by isolating the qdr_delivery_t handling code.  This code is currently residing in the transfer.c source file which also contains various link and connection state handling.  The qdr_delivery_t structure definition should also be moved out of the common router core private header file.
> This change will simply move delivery code to its own delivery.c and delivery.h in the router_core directory (for now).  No functional changes will be made, though some method names may be changed for consistency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org